Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update README.mdxxxx xx JIRA-1 #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: update README.mdxxxx xx JIRA-1 #46

wants to merge 1 commit into from

Conversation

christophehurpeau
Copy link
Member

@christophehurpeau christophehurpeau commented Aug 5, 2020 •
edited by reviewflow-dev bot

Context

Explain here why this PR is needed

Solution

If needed, explain here the solution you chose for this

@reviewflow-dev
Copy link

reviewflow-dev bot commented Aug 5, 2020 •
edited

Infos:

JIRA issue: JIRA-1

Options:

  • 🚦 automerge: Automatically merge when this PR is ready and has no failed statuses. When the repository requires branches to be up to date before merging, it merges default branch, with a queue per repo to prevent multiple merges when several PRs are ready. A fail job prevents the merge.
  • 🚦 skip-ci: Add [skip ci] on merge commit when merge is done with autoMerge.
  • ♻️ Automatically delete the branch after this PR is merged

@reviewflow-dev reviewflow-dev bot added 👌 code/needs-review Synced by reviewflow for code/needs-review 👌 code/review-requested Synced by reviewflow for code/review-requested labels Aug 5, 2020
@reviewflow-dev reviewflow-dev bot added 👌 code/approved Synced by reviewflow for code/approved and removed 👌 code/needs-review Synced by reviewflow for code/needs-review 👌 code/review-requested Synced by reviewflow for code/review-requested labels Aug 5, 2020
@christophehurpeau
Copy link
Member Author

test

2 similar comments
@christophehurpeau
Copy link
Member Author

test

@christophehurpeau
Copy link
Member Author

test

@christophehurpeau christophehurpeau added 🔄 update branch Synced by reviewflow for merge/update-branch and removed 🔄 update branch Synced by reviewflow for merge/update-branch labels Sep 20, 2020
@reviewflow-dev
Copy link

@christophehurpeau could not update branch: base already contains the head, nothing to merge.

@reviewflow-dev reviewflow-dev bot removed the 🔄 update branch Synced by reviewflow for merge/update-branch label Sep 20, 2020
christophehurpeau
christophehurpeau commented Sep 28, 2020
View reviewed changes
README.md
@@ -3,3 +3,5 @@
test

now supports breaking changes !

test
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
test
test

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
test

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
test

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
test

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
test

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
test
testsdads

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blablbaa

Suggested change
test

asdasdasdasda asd asd

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blablbaa

asdasdasdasda asd asd

adsasd

@christophehurpeau christophehurpeau added 🔄 update branch Synced by reviewflow for merge/update-branch and removed 🔄 update branch Synced by reviewflow for merge/update-branch labels Dec 13, 2020
@reviewflow-dev
Copy link

@christophehurpeau could not update branch: base already contains the head, nothing to merge.

@reviewflow-dev reviewflow-dev bot removed the 🔄 update branch Synced by reviewflow for merge/update-branch label Dec 13, 2020
@christophehurpeau
Copy link
Member Author

test

@reviewflow-dev reviewflow-dev bot added 👌 code/needs-review Synced by reviewflow for code/needs-review and removed 👌 code/approved Synced by reviewflow for code/approved labels Dec 20, 2020
@reviewflow-dev reviewflow-dev bot removed the 👌 code/needs-review Synced by reviewflow for code/needs-review label Dec 20, 2020
@reviewflow-dev reviewflow-dev bot added the 👌 code/needs-review Synced by reviewflow for code/needs-review label Dec 20, 2020
@reviewflow-dev reviewflow-dev bot removed the 👌 code/needs-review Synced by reviewflow for code/needs-review label Dec 20, 2020
@reviewflow-dev reviewflow-dev bot added the 👌 code/needs-review Synced by reviewflow for code/needs-review label Dec 20, 2020
@reviewflow-dev reviewflow-dev bot added the 👌 code/review-requested Synced by reviewflow for code/review-requested label Jan 30, 2021
@christophehurpeau
Copy link
Member Author

t

@christophehurpeau christophehurpeau changed the title Update README.md Update README.md Mar 14, 2021
@christophehurpeau christophehurpeau changed the title Update README.md feat: update README.md Mar 14, 2021
@reviewflow-dev reviewflow-dev bot changed the title feat: update README.md feat: update README.md Mar 14, 2021
@christophehurpeau christophehurpeau changed the title feat: update README.md feat: update README.md JIRA-1 Mar 14, 2021
@christophehurpeau christophehurpeau changed the title feat: update README.md JIRA-1 feat: update README.md JIRA-1 Mar 14, 2021
@reviewflow-dev reviewflow-dev bot changed the title feat: update README.md JIRA-1 feat: update README.md JIRA-1 Mar 14, 2021
@christophehurpeau christophehurpeau changed the title feat: update README.md JIRA-1 feat: update README.md JIRA-1 Mar 14, 2021
@reviewflow-dev reviewflow-dev bot changed the title feat: update README.md JIRA-1 feat: update README.md JIRA-1 Mar 14, 2021
@christophehurpeau christophehurpeau changed the title feat: update README.md JIRA-1 feat: update README.mdxxx JIRA-1 Mar 14, 2021
@christophehurpeau christophehurpeau changed the title feat: update README.mdxxx JIRA-1 feat: update README.mdxx xx JIRA-1 Mar 14, 2021
@christophehurpeau christophehurpeau changed the title feat: update README.mdxx xx JIRA-1 feat: update README.mdxxxx xx JIRA-1 Mar 17, 2021
@reviewflow-dev
Copy link

reviewflow-dev bot commented Sep 5, 2022

@christophehurpeau : Force-pushing is a bad practice

1 similar comment
@reviewflow-dev
Copy link

reviewflow-dev bot commented Sep 5, 2022

@christophehurpeau : Force-pushing is a bad practice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-reviewflow chris-reviewflow Awaiting requested review from chris-reviewflow

Assignees

@christophehurpeau christophehurpeau

Labels
👌 code/needs-review Synced by reviewflow for code/needs-review 👌 code/review-requested Synced by reviewflow for code/review-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@christophehurpeau @chris-reviewflow