Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scope)!: test test test test [no issue] #50

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix(scope)!: test test test test [no issue] #50

wants to merge 5 commits into from

Conversation

christophehurpeau
Copy link
Member

@christophehurpeau christophehurpeau commented Mar 17, 2021 •
edited by reviewflow-dev bot

Context

Explain here why this PR is needed

Solution

If needed, explain here the solution you chose for this

@christophehurpeau christophehurpeau changed the title fix: Ebook : add missing slug and order property to Chapter resource [no issue] fix: Ebook : add missing slug and order property to Chapter resource [no issue] Mar 17, 2021
@reviewflow-dev
Copy link

reviewflow-dev bot commented Mar 17, 2021 •
edited by chris-reviewflow

Commits Notes:

Breaking Changes:

  • test new breaking change (16b1bc3)
  • other breaking change (6c5d2a0)
  • latest breaking change format (5623c17)

Options:

  • 🚦 automerge: Automatically merge when this PR is ready and has no failed statuses. When the repository requires branches to be up to date before merging, it merges default branch, with a queue per repo to prevent multiple merges when several PRs are ready. A fail job prevents the merge.
  • 🚦 skip-ci: Add [skip ci] on merge commit when merge is done with autoMerge.
  • ♻️ Automatically delete the branch after this PR is merged.

@reviewflow-dev reviewflow-dev bot changed the title fix: Ebook : add missing slug and order property to Chapter resource [no issue] fix: Ebook : add missing slug and order property to Chapter resource [no issue] Mar 17, 2021
@christophehurpeau christophehurpeau changed the title fix: Ebook : add missing slug and order property to Chapter resource [no issue] fix: Ebook : add missing slug and order property to Chapter resource [no issue] Mar 17, 2021
@reviewflow-dev reviewflow-dev bot changed the title fix: Ebook : add missing slug and order property to Chapter resource [no issue] fix: Ebook : add missing slug and order property to Chapter resource [no issue] Mar 17, 2021
@christophehurpeau christophehurpeau changed the title fix: Ebook : add missing slug and order property to Chapter resource [no issue] fix: Ebook : add missing slug and order property to Chapter resource [no issue] Mar 17, 2021
@reviewflow-dev reviewflow-dev bot changed the title fix: Ebook : add missing slug and order property to Chapter resource [no issue] fix: Ebook : add missing slug and order property to Chapter resource [no issue] Mar 17, 2021
@christophehurpeau christophehurpeau changed the title fix: Ebook : add missing slug and order property to Chapter resource [no issue] fix: Ebook : add missing slug and order property to Chapter resource [no issue] Mar 17, 2021
@reviewflow-dev reviewflow-dev bot changed the title fix: Ebook : add missing slug and order property to Chapter resource [no issue] fix: Ebook : add missing slug and order property to Chapter resource [no issue] Mar 17, 2021
@christophehurpeau christophehurpeau changed the title fix: Ebook : add missing slug and order property to Chapter resource [no issue] fix: Ebook : add missing slug and order property to Chapter resource [no issue] Mar 17, 2021
@reviewflow-dev reviewflow-dev bot changed the title fix: Ebook : add missing slug and order property to Chapter resource [no issue] fix: Ebook : add missing slug and order property to Chapter resource [no issue] Mar 17, 2021
@christophehurpeau christophehurpeau changed the title fix: Ebook : add missing slug and order property to Chapter resource [no issue] fix: Ebook : add missing slug and order property to Chapter resource [no issue] Mar 17, 2021
@reviewflow-dev reviewflow-dev bot changed the title fix: Ebook : add missing slug and order property to Chapter resource [no issue] fix: Ebook : add missing slug and order property to Chapter resource [no issue] Mar 17, 2021
@christophehurpeau christophehurpeau changed the title fix: Ebook : add missing slug and order property to Chapter resource [no issue] fix: Ebook : add missing slug and order property to Chapter resource [no issue]fix: Ebook : add missing slug and order property to Chapter resource [no issue] Mar 17, 2021
@christophehurpeau christophehurpeau changed the title fix: Ebook : add missing slug and order property to Chapter resource [no issue]fix: Ebook : add missing slug and order property to Chapter resource [no issue] fix: Ebook : add missing slug and order property to Chapter resource [no issue]fix: Ebook : add missing slug and order property to Chapter resource [no issue] Mar 17, 2021
@reviewflow-dev reviewflow-dev bot changed the title fix: Ebook : add missing slug and order property to Chapter resource [no issue]fix: Ebook : add missing slug and order property to Chapter resource [no issue] fix: Ebook : add missing slug and order property to Chapter resource [no issue]fix: Ebook : add missing slug and order property to Chapter resource [no issue] Mar 17, 2021
@christophehurpeau christophehurpeau changed the title fix: Ebook : add missing slug and order property to Chapter resource [no issue]fix: Ebook : add missing slug and order property to Chapter resource [no issue] fix: Ebook : add missing slug and order property to Chapter resource [no issue] Mar 23, 2021
@christophehurpeau christophehurpeau changed the title fix: Ebook : add missing slug and order property to Chapter resource [no issue] fix: Ebook : add missing slug and order property to Chapter resource [no issue] Mar 23, 2021
@reviewflow-dev reviewflow-dev bot changed the title fix: Ebook : add missing slug and order property to Chapter resource [no issue] fix: Ebook : add missing slug and order property to Chapter resource [no issue] Mar 23, 2021
@christophehurpeau christophehurpeau changed the title fix: Ebook : add missing slug and order property to Chapter resource [no issue] fix: Ebook : add missing slug and order property to Chapter resource [no issue] Mar 23, 2021
@reviewflow-dev reviewflow-dev bot changed the title fix: Ebook : add missing slug and order property to Chapter resource [no issue] fix: Ebook : add missing slug and order property to Chapter resource [no issue] Mar 23, 2021
@christophehurpeau christophehurpeau changed the title fix: Ebook : add missing slug and order property to Chapter resource [no issue] fix: Ebook : add missing slug and order property to Chapter resource [no issue] Mar 23, 2021
@reviewflow-dev reviewflow-dev bot changed the title fix: Ebook : add missing slug and order property to Chapter resource [no issue] fix: Ebook : add missing slug and order property to Chapter resource [no issue] Mar 23, 2021
@christophehurpeau christophehurpeau changed the title fix: Ebook : add missing slug and order property to Chapter resource [no issue] fix: Ebook : add missing slug and order property to Chapter resource [no issue] Mar 23, 2021
@reviewflow-dev reviewflow-dev bot changed the title fix: Ebook : add missing slug and order property to Chapter resource [no issue] fix: Ebook : add missing slug and order property to Chapter resource [no issue] Mar 23, 2021
@christophehurpeau christophehurpeau changed the title fix: Ebook : add missing slug and order property to Chapter resource [no issue] fix: ebook endpoint add chapter slug order [no issue] Mar 23, 2021
@christophehurpeau christophehurpeau changed the title fix: ebook endpoint add chapter slug order [no issue] fix: ebook endpoint add chapter slug order [no issue] Mar 23, 2021
@reviewflow-dev reviewflow-dev bot changed the title fix: ebook endpoint add chapter slug order [no issue] fix: ebook endpoint add chapter slug order [no issue] Mar 23, 2021
@christophehurpeau christophehurpeau changed the title fix: ebook endpoint add chapter slug order [no issue] fix: ebook endpoint add chapter slug order [no issue] May 8, 2021
@christophehurpeau
feat: add new breaking change
16b1bc3 
BREAKING CHANGE: test new breaking change
@reviewflow-dev reviewflow-dev bot added the ⚠️ Breaking Changes Synced by reviewflow for breaking-changes label Jan 23, 2022
chris-reviewflow
chris-reviewflow requested changes Feb 20, 2022
View reviewed changes
Copy link
Collaborator

@chris-reviewflow chris-reviewflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asdasd

README.md
@@ -5,3 +5,8 @@ test
now supports breaking changes !

test
asdasdasd
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
asdasdasd

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asdasd

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asdasd

@reviewflow-dev reviewflow-dev bot removed the 👌 code/review-requested Synced by reviewflow for code/review-requested label Feb 20, 2022
chris-reviewflow
chris-reviewflow requested changes Feb 20, 2022
View reviewed changes
Copy link
Collaborator

@chris-reviewflow chris-reviewflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asdasd

@reviewflow-dev reviewflow-dev bot added the 👌 code/review-requested Synced by reviewflow for code/review-requested label Feb 20, 2022
@reviewflow-dev reviewflow-dev bot added 👌 code/approved Synced by reviewflow for code/approved and removed 👌 code/needs-review Synced by reviewflow for code/needs-review 👌 code/review-requested Synced by reviewflow for code/review-requested 👌 code/changes-requested Synced by reviewflow for code/changes-requested labels Feb 20, 2022
@reviewflow-dev reviewflow-dev bot added 👌 code/needs-review Synced by reviewflow for code/needs-review and removed 👌 code/approved Synced by reviewflow for code/approved labels Feb 20, 2022
@chris-reviewflow
Copy link
Collaborator

Codecov Report

Merging #1534 (11d5702) into main (48f429f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1534   +/-   ##
=======================================
  Coverage   85.29%   85.29%           
=======================================
  Files         143      143           
  Lines        1530     1530           
  Branches      431      431           
=======================================
  Hits         1305     1305           
  Misses        221      221           
  Partials        4        4
Flag Coverage Δ
native 86.09% <ø> (ø)
web 85.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f414766...11d5702. Read the comment docs.

@reviewflow-dev
Copy link

reviewflow-dev bot commented Aug 12, 2022 •
edited

Progress

☑️ Step 1: ✏️ Write code
☑️ Step 2: 💚 Checks
⬜ Step 3: 👌 Code Review
⬜ Step 4: 🚦 Merge Pull Request

Commits Notes:

Breaking Changes:

  • test new breaking change (16b1bc3)
  • other breaking change (6c5d2a0)
  • latest breaking change format (5623c17)

Options:

  • 🚦 automerge: Automatically merge when this PR is ready and has no failed statuses. When the repository requires branches to be up to date before merging, it merges default branch, with a queue per repo to prevent multiple merges when several PRs are ready. A fail job prevents the merge.
  • 🚦 skip-ci: Add [skip ci] on merge commit when merge is done with autoMerge.
  • ♻️ Automatically delete the branch after this PR is merged.

Actions:

  • 🐛 Force updating reviewflow checks for this PR. Use this to try to fix reviewflow checks that are still missing/pending, which might happen if webhook failed or something bad happened when reviewflow tried to send the status check to github.
  • 🔄 update branch: Merge base branch in this PR's branch. Only works if merging is possible without conflicts.

@christophehurpeau
Copy link
Member Author

Codecov Report

Merging #1534 (11d5702) into main (48f429f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1534   +/-   ##
=======================================
  Coverage   85.29%   85.29%           
=======================================
  Files         143      143           
  Lines        1530     1530           
  Branches      431      431           
=======================================
  Hits         1305     1305           
  Misses        221      221           
  Partials        4        4
Flag Coverage Δ
native 86.09% <ø> (ø)
web 85.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f414766...11d5702. Read the comment docs.

chris-reviewflow
chris-reviewflow reviewed Aug 12, 2022
View reviewed changes
README.md
@@ -5,3 +5,9 @@ test
now supports breaking changes !
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asdasd

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asdasd

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asdasd

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asdasd

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asdasd

christophehurpeau
christophehurpeau commented Aug 12, 2022
View reviewed changes
README.md
@@ -6,3 +6,4 @@ now supports breaking changes !

test
asdasdasd
breaking change
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

@chris-reviewflow
Copy link
Collaborator

test

@christophehurpeau christophehurpeau changed the title fix: test test test test [no issue] fix: test test test test [no issue] Mar 13, 2023
@reviewflow-dev reviewflow-dev bot changed the title fix: test test test test [no issue] fix!: test test test test [no issue] Mar 13, 2023
@christophehurpeau christophehurpeau changed the title fix!: test test test test [no issue] fix(scope): test test test test [no issue] Mar 13, 2023
@reviewflow-dev reviewflow-dev bot changed the title fix(scope): test test test test [no issue] fix(scope)!: test test test test [no issue] Mar 13, 2023
@christophehurpeau christophehurpeau changed the title fix(scope)!: test test test test [no issue] fix(scope)!: test test test test [no issue] Apr 3, 2023
@reviewflow-dev reviewflow-dev bot changed the title fix(scope)!: test test test test [no issue] fix(scope)!: test test test test [no issue] Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-reviewflow chris-reviewflow chris-reviewflow left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
👌 code/needs-review Synced by reviewflow for code/needs-review ⚠️ Breaking Changes Synced by reviewflow for breaking-changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@christophehurpeau @chris-reviewflow