Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't iterate over String in addParent #89

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vjpr
Copy link

@vjpr vjpr commented Feb 28, 2016

#88

@blitzrk
Copy link

blitzrk commented Mar 28, 2016

Before I manually applied this patch, I was getting

events.js:154
      throw er; // Unhandled 'error' event
      ^
RangeError: Maximum call stack size exceeded
    at formatPrimitive (util.js:452:25)
    at formatValue (util.js:261:19)
    at inspect (util.js:143:10)
    at exports.format (util.js:24:24)
    at Console.log (console.js:39:34)
    at addParent (/home/ben/Projects/asciidoc-blog/node_modules/css/lib/parse/index.js:584:13)
    at addParent (/home/ben/Projects/asciidoc-blog/node_modules/css/lib/parse/index.js:589:7)
    at addParent (/home/ben/Projects/asciidoc-blog/node_modules/css/lib/parse/index.js:589:7)
    at addParent (/home/ben/Projects/asciidoc-blog/node_modules/css/lib/parse/index.js:589:7)
    at addParent (/home/ben/Projects/asciidoc-blog/node_modules/css/lib/parse/index.js:589:7)

while using gulp-sass, even with three line CSS files (and no other gulp plugins). Not sure if so much recursion is normal, but this at least removes the bug's symptoms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants