Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip unauthorized pools in the rbd driver. #1170

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

highfly22
Copy link

Try to use rexray in the non-privilege account.

@codecov-io
Copy link

codecov-io commented Feb 9, 2018

Codecov Report

Merging #1170 into master will decrease coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1170      +/-   ##
==========================================
- Coverage   34.58%   34.25%   -0.34%     
==========================================
  Files          36       36              
  Lines        2362     2362              
==========================================
- Hits          817      809       -8     
- Misses       1441     1450       +9     
+ Partials      104      103       -1
Impacted Files Coverage Δ
...storage/drivers/storage/vfs/storage/vfs_storage.go 39.54% <0%> (-2.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1608180...f65c7df. Read the comment docs.

@akutz
Copy link
Member

akutz commented May 18, 2018

Hi @highfly22,

I like the change, but I wonder if @codenrhoden thinks it should be configurable? If so, default to skip/error?

Please go ahead and rebase onto master so the PR is up-to-date prior to merge. Thanks!

@codenrhoden
Copy link
Member

@highfly22 I would prefer to see this as configurable. If you just blindly ignore the inability to list images in a pool, you have no way to know if it's because your Auth key doesn't allow you access to that specific pool, or if your key is completely invalid.

A config option to enable skipping inaccessible pools would be good, and I would want to see a debug log entry saying that the pool was skipped, such that if you turn on debugging you see it happening.

@akutz
Copy link
Member

akutz commented Jun 11, 2018

@highfly22 ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants