Improve initscript behavior

[jggc]

Current initscript does not work as intended :

• When is starts the service it stays in the foreground, initscripts
  should run daemons in the background
• It logs to the tty, initscripts should redirect their output to
  somewhere that makes sense.

So here is this patch that will send the appropriate targets of the
rexray service in the background and only output minimal informative
logging to the tty, any other logs are redirected into
/var/log/rexray/initscript.log

Also refactored to use "${}" across the script

[codecov-io]

Codecov Report

Merging #1199 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #1199      +/-   ##
=========================================
- Coverage   34.25%   34.2%   -0.05%     
=========================================
  Files          36      36              
  Lines        2362    2362              
=========================================
- Hits          809     808       -1     
- Misses       1450    1451       +1     
  Partials      103     103

Impacted Files	Coverage Δ
libstorage/api/types/types_localdevices.go	84.21% <0%> (-1.76%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c38bb7...1707c55. Read the comment docs.

[clintkitson]

Thank you!

…

On Fri, Mar 30, 2018 at 11:23 AM jggc ***@***.***> wrote: Current initscript does not work as intended : - When is starts the service it stays in the foreground, initscripts should run daemons in the background - It logs to the tty, initscripts should redirect their output to somewhere that makes sense. So here is this patch that will send the appropriate targets of the rexray service in the background and only output minimal informative logging to the tty, any other logs are redirected into /var/log/rexray/initscript.log Also refactored to use "${}" across the script ------------------------------ You can view, comment on, or merge this pull request online at: #1199 Commit Summary - Improve initscript behavior File Changes - *M* cli/installer.go <https://github.com/rexray/rexray/pull/1199/files#diff-0> (37) Patch Links: - https://github.com/rexray/rexray/pull/1199.patch - https://github.com/rexray/rexray/pull/1199.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1199>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABVMMbSBhorcI8WtVD8GvF2NbjFORD_Mks5tjngygaJpZM4TB_T1> .

[akutz]

Hi @jggc,

I'm happy to accept this PR, but please:

1. Rebase onto master
2. Split the current commit into two:
   • Commit 1 - Amazon Linux Support
   • Commit 2 - The global change to ${}

Thank you!

[akutz]

Ping @jggc