Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add S3FS_CONVERTUNDERSCORES env into s3 conf.json #1265

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chaiebaymen
Copy link

the purpose is to take choice to convert underscore between my stack name and the service. because as you know aws S3 don't support _ in buckets names.
please i wish that you will making some stuff for that.
i'm waiting for your feedback and thanks for your attention.

want to take option to convert underscore between my stack name and the service.
please i wish that you will making some stuff for that.
thanks.
@CLAassistant
Copy link

CLAassistant commented Sep 23, 2018

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-io
Copy link

Codecov Report

Merging #1265 into master will increase coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1265      +/-   ##
==========================================
+ Coverage   34.25%   34.54%   +0.29%     
==========================================
  Files          36       36              
  Lines        2362     2362              
==========================================
+ Hits          809      816       +7     
+ Misses       1450     1442       -8     
- Partials      103      104       +1
Impacted Files Coverage Δ
libstorage/api/types/types_localdevices.go 84.21% <0%> (-1.76%) ⬇️
...storage/drivers/storage/vfs/storage/vfs_storage.go 42.15% <0%> (+2.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a6e866...53b1905. Read the comment docs.

@clintkitson
Copy link
Member

Hello @chaiebaymen,

Does this fix work? I don't see this as an actual parameter. It looks like someone needs to enable this as a capability in the driver to be able to expose it to the managed plugin.

@chaiebaymen
Copy link
Author

chaiebaymen commented Sep 28, 2018

Hello @clintkitson ,
Firstly, thanks for your feedback, exactly i want to expose this alias to be able to integrate my docker volume as s3 bucket into my docker stack. Actually, once i deloy the stack ( docker stack deploy -c stack-file.yml stacknam) a volume will be mounted as s3 bucket like stackname_volumename and eventually it’s not acceptable to create bucket with underscored name. My purpose is to make an option for the plugin in order to activate the conversion of the underscore to a dash for exemple.
Like as noticed in #1020

@rimoore
Copy link

rimoore commented Mar 13, 2019

I am having the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants