-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continuation of #1268 - WiP - Look at availability zones when searching for EFS mount targets #1288
base: master
Are you sure you want to change the base?
Conversation
Before this commit the EFS driver would select a mount target based on the subnet it is in. All mount targets in subnets not equal to the subnet of the host would be ignored. This is incorrect behaviour as subnets do not restrict access to a mount target. Now the mount target selection is implemented by looking at the availability zone of the mount target and host as these must be equal for the host to reach the mount target.
Codecov Report
@@ Coverage Diff @@
## master #1288 +/- ##
=======================================
Coverage 34.25% 34.25%
=======================================
Files 36 36
Lines 2362 2362
=======================================
Hits 809 809
Misses 1450 1450
Partials 103 103 Continue to review full report at Codecov.
|
We are looking for the community to validate the testing in AWS for this patch. @SijmenHuizenga Any feedback for this continuation of your work? |
@clintkitson Sorry for the embarrassing late response. I won't be working on this anymore. |
@clintkitson Hi I am also trying to put my EFS mount points in a different subnet than the Docker host, and I need this change in order for it to work. Is this change going to be finished, or should I look for a different solution? |
Since we're running into the same issue in #1228 I'd like to pick up Sijmen Huizenga's work from #1268.
I've fixed the hound comments. Could a maintainer take a look if something else needs to be done?
@SijmenHuizenga Could you sign the CLA?