Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard operations that mutates an EBS volume with a Mutex #1345

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

remilapeyre
Copy link

Closes #1284

@CLAassistant
Copy link

CLAassistant commented May 17, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

Codecov Report

Merging #1345 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1345   +/-   ##
=======================================
  Coverage   34.20%   34.20%           
=======================================
  Files          36       36           
  Lines        2362     2362           
=======================================
  Hits          808      808           
  Misses       1451     1451           
  Partials      103      103           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3620358...4a77613. Read the comment docs.

@nbryant42
Copy link

nbryant42 commented Nov 26, 2022

Looks good to me, except the attempt to fix the find command in the Makefile is still not quite right.

Merged this into a fork https://github.com/nbryant42/rexray/tree/collected-prs which I am using to build https://gallery.ecr.aws/j1l5j1d1/rexray-ebs

@nbryant42
Copy link

On my local branch mentioned above, I now see intermittent mount failures when ECS tries to place a task, with the context deadline exceeded message. Not sure if this PR is missing an edge case that can cause more retries, or if the problem lies elsewhere.

@nbryant42
Copy link

Reverted this PR from the binaries I'm publishing, because it seems to be causing regressions.

Copy link

@nbryant42 nbryant42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing approval. seems to cause regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Volume attachment race condition
4 participants