Skip to content

Commit

Permalink
fix: Export all Request object types from resources/*.ts. (#193)
Browse files Browse the repository at this point in the history
Rename getStatsRequest to GetStatsRequest
Rename getGearByIdRequest to GetGearByIdRequest
Rename getLoggedInAthleteClubsRequest to GetLoggedInAthleteClubsRequest
Build and unit tests pass.
  • Loading branch information
jpravetz committed Oct 10, 2023
1 parent f8496a5 commit ac6d92e
Show file tree
Hide file tree
Showing 12 changed files with 13,641 additions and 9,054 deletions.
22,611 changes: 13,599 additions & 9,012 deletions package-lock.json

Large diffs are not rendered by default.

18 changes: 9 additions & 9 deletions src/resources/activities.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
} from '../models'
import { Request } from '../request'

type CreateActivityRequest = {
export type CreateActivityRequest = {
name: string
type: ActivityType
start_date_local: string
Expand All @@ -20,45 +20,45 @@ type CreateActivityRequest = {
commute?: number
}

type GetActivityByIdRequest = {
export type GetActivityByIdRequest = {
id: number
include_all_efforts?: boolean
}

type GetCommentsByActivityIdRequest = {
export type GetCommentsByActivityIdRequest = {
id: number
page?: number
per_page?: number
}

type GetKudoersByActivityIdRequest = {
export type GetKudoersByActivityIdRequest = {
id: number
page?: number
per_page?: number
}

type GetLapsByActivityIdRequest = {
export type GetLapsByActivityIdRequest = {
id: number
}

type GetPhotosByActivityIdRequest = {
export type GetPhotosByActivityIdRequest = {
id: number
photo_sources?: boolean
size?: number
}

type GetZonesByActivityIdRequest = {
export type GetZonesByActivityIdRequest = {
id: number
}

type GetLoggedInAthleteActivitiesRequest = {
export type GetLoggedInAthleteActivitiesRequest = {
before?: number
after?: number
page?: number
per_page?: number
}

type UpdateActivityByIdRequest = {
export type UpdateActivityByIdRequest = {
id: number
name?: string
type?: ActivityType
Expand Down
6 changes: 3 additions & 3 deletions src/resources/athletes.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import { ActivityStats, DetailedAthlete, Zones } from '../models'
import { Request } from '../request'

type getStatsRequest = {
export type GetStatsRequest = {
id: number
}

type UpdateLoggedInAthleteRequest = {
export type UpdateLoggedInAthleteRequest = {
weight: number
}

Expand All @@ -31,7 +31,7 @@ export class Athletes {
}

async getStats(
params: getStatsRequest,
params: GetStatsRequest,
access_token?: string,
): Promise<ActivityStats> {
const { id } = params
Expand Down
12 changes: 6 additions & 6 deletions src/resources/clubs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,29 +6,29 @@ import {
} from '../models'
import { Request } from '../request'

type GetClubActivitiesByIdRequest = {
export type GetClubActivitiesByIdRequest = {
id: number
page?: number
per_page?: number
}

type GetClubAdminsByIdRequest = {
export type GetClubAdminsByIdRequest = {
id: number
page?: number
per_page?: number
}

type GetClubByIdRequest = {
export type GetClubByIdRequest = {
id: number
}

type GetClubMembersByIdRequest = {
export type GetClubMembersByIdRequest = {
id: number
page?: number
per_page?: number
}

type getLoggedInAthleteClubsRequest = {
export type GetLoggedInAthleteClubsRequest = {
page?: number
per_page?: number
}
Expand Down Expand Up @@ -85,7 +85,7 @@ export class Clubs {
}

async getLoggedInAthleteClubs(
params?: getLoggedInAthleteClubsRequest,
params?: GetLoggedInAthleteClubsRequest,
access_token?: string,
): Promise<SummaryClub[]> {
return await this.request.makeApiRequest<SummaryClub[]>(
Expand Down
4 changes: 2 additions & 2 deletions src/resources/gears.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { DetailedGear } from '../models'
import { Request } from '../request'

type getGearByIdRequest = {
export type GetGearByIdRequest = {
id: number
}

Expand All @@ -13,7 +13,7 @@ export class Gears {
}

async getGearById(
params: getGearByIdRequest,
params: GetGearByIdRequest,
access_token?: string,
): Promise<DetailedGear> {
const { id } = params
Expand Down
8 changes: 4 additions & 4 deletions src/resources/routes.ts
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
import { Route } from '../models'
import { Request } from '../request'

type GetRouteAsGPXRequest = {
export type GetRouteAsGPXRequest = {
id: number
}

type GetRouteAsTCXRequest = {
export type GetRouteAsTCXRequest = {
id: number
}

type GetRouteByIdRequest = {
export type GetRouteByIdRequest = {
id: number
}

type GetRoutesByAthleteIdRequest = {
export type GetRoutesByAthleteIdRequest = {
id: number
page?: number
per_page?: number
Expand Down
4 changes: 2 additions & 2 deletions src/resources/runningRaces.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import { RunningRace } from '../models'
import { Request } from '../request'

type GetRunningRaceByIdRequest = {
export type GetRunningRaceByIdRequest = {
id: number
}

type GetRunningRacesRequest = {
export type GetRunningRacesRequest = {
year?: number
}

Expand Down
4 changes: 2 additions & 2 deletions src/resources/segmentEfforts.ts
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
import { DetailedSegmentEffort } from '../models'
import { Request } from '../request'

type GetEffortsBySegmentIdRequest = {
export type GetEffortsBySegmentIdRequest = {
segment_id: number
start_date_local?: string
end_date_local?: string
per_page?: number
}

type GetSegmentEffortByIdRequest = {
export type GetSegmentEffortByIdRequest = {
id: number
}

Expand Down
10 changes: 5 additions & 5 deletions src/resources/segments.ts
Original file line number Diff line number Diff line change
@@ -1,25 +1,25 @@
import { DetailedSegment, ExplorerResponse, SummarySegment } from '../models'
import { Request } from '../request'

type ActivityType = 'running' | 'ridding'
export type ActivityType = 'running' | 'ridding'

type ExploreSegmentsRequest = {
export type ExploreSegmentsRequest = {
bounds: string
activity_type?: ActivityType
min_cat?: number
max_cat?: number
}

type GetLoggedInAthleteStarredSegmentsRequest = {
export type GetLoggedInAthleteStarredSegmentsRequest = {
page?: number
per_page?: number
}

type GetSegmentByIdRequest = {
export type GetSegmentByIdRequest = {
id: number
}

type StarSegmentRequest = {
export type StarSegmentRequest = {
id: number
starred: boolean
}
Expand Down
8 changes: 4 additions & 4 deletions src/resources/streams.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,21 @@ import { StreamKeys } from '../enums'
import { StreamSet } from '../models'
import { Request } from '../request'

type GetActivityStreamsRequest = {
export type GetActivityStreamsRequest = {
id: number
keys: StreamKeys | StreamKeys[]
}

type GetRouteStreamsRequest = {
export type GetRouteStreamsRequest = {
id: number
}

type GetSegmentEffortStreamsRequest = {
export type GetSegmentEffortStreamsRequest = {
id: number
keys: StreamKeys | StreamKeys[]
}

type GetSegmentStreamsRequest = {
export type GetSegmentStreamsRequest = {
id: number
keys: StreamKeys | StreamKeys[]
}
Expand Down
6 changes: 3 additions & 3 deletions src/resources/subscriptions.ts
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
import { Request } from '../request'

type Subscription = {
export type Subscription = {
id: number
}

type SubscriptionCreationRequest = {
export type SubscriptionCreationRequest = {
callback_url: string
verify_token: string
}

type SubscriptionCreationResponse = {
export type SubscriptionCreationResponse = {
id: number
}

Expand Down
4 changes: 2 additions & 2 deletions src/resources/uploads.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { ReadStream } from 'fs'
import { Upload } from '../models'
import { Request } from '../request'

type CreateUploadRequest = {
export type CreateUploadRequest = {
file: ReadStream
data_type: 'fit' | 'fit.gz' | 'tcx' | 'tcx.gz' | 'gpx' | 'gpx.gz'
name?: string
Expand All @@ -14,7 +14,7 @@ type CreateUploadRequest = {
external_id?: string
}

type GetUploadByIdRequest = {
export type GetUploadByIdRequest = {
uploadId: number
}

Expand Down

0 comments on commit ac6d92e

Please sign in to comment.