Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump project dependnecies, review libs #331

Merged
merged 6 commits into from
Dec 12, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintrc.angular.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ module.exports = {
},
},
{
files: ['**/hammerjs-gesture.config.ts', '**/*.store.ts'],
files: ['**/hammerjs-gesture.config.ts', '**/*.state.ts'],
rules: {
'@angular-eslint/use-injectable-provided-in': 'off',
},
Expand Down
8 changes: 4 additions & 4 deletions .eslintrc.module-boundaries.js
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ const clientConstraints = [
},
{
sourceTag: 'scope:client-services',
onlyDependOnLibsWithTags: ['scope:client-util', 'scope:client-unit-testing', 'scope:proto'],
onlyDependOnLibsWithTags: ['scope:client-util'],
},
{
sourceTag: 'scope:client-componnents',
Expand Down Expand Up @@ -237,7 +237,7 @@ const clientConstraints = [
'scope:client-store-user',
'scope:client-services',
'scope:client-chatbot',
'scope:client-components',
'scope:client-core-components',
'scope:client-core',
'scope:client-diagnostics',
'scope:client-material',
Expand All @@ -247,7 +247,7 @@ const clientConstraints = [
],
},
{
sourceTag: 'scope:client-components',
sourceTag: 'scope:client-core-components',
onlyDependOnLibsWithTags: [
'scope:client-material',
'scope:client-store-chatbot',
Expand All @@ -263,7 +263,7 @@ const clientConstraints = [
onlyDependOnLibsWithTags: ['scope:client-util'],
},
{
sourceTag: 'scope:client-components-e2e',
sourceTag: 'scope:client-core-components-e2e',
onlyDependOnLibsWithTags: ['scope:client-util'],
},
{
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ jobs:
run: yarn workspace:integrity-check

- name: Install project dependencies
run: yarn install --frozen-lockfile
run: yarn install:ci

- name: Unit test all (with code coverage)
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
run: echo fs.inotify.max_user_watches=524288 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p

- name: Install project dependencies
run: yarn install --frozen-lockfile
run: yarn install:ci

- name: Install Cypress
run: npx cypress install
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/pr-validation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ jobs:

- name: Install project dependencies
if: steps.changes.outputs.nx == 'true'
run: yarn install --frozen-lockfile
run: yarn install:ci

- name: Lint affected
if: steps.changes.outputs.nx == 'true'
Expand All @@ -133,4 +133,6 @@ jobs:

- name: Build storybook
if: steps.changes.outputs.nx == 'true'
run: npx nx run documentation:build-storybook
run: |
echo "Broken. Update the package when it's patched. See https://github.com/storybookjs/storybook/issues/16977"
npx nx run documentation:build-storybook || true
2 changes: 1 addition & 1 deletion .github/workflows/trunk-on-push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ jobs:

- name: Install project dependencies
if: steps.changes.outputs.nx == 'true'
run: yarn install --frozen-lockfile
run: yarn install:ci

- name: Lint all
if: steps.changes.outputs.nx == 'true'
Expand Down
2 changes: 1 addition & 1 deletion .ncurc.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"reject": ["eslint", "graphql", "typescript"],
"reject": ["graphql", "typescript"],
"timeout": 90000
}
3 changes: 0 additions & 3 deletions .storybook/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@ module.exports = {
],
stories: [],
webpackFinal: async (config) => {
// for backwards compatibility call the `rootWebpackConfig`
// this can be removed once that one is migrated fully to
// use the `webpackFinal` property in the `main.js` file
const tsPaths = new TsconfigPathsPlugin({
configFile: './tsconfig.base.json',
});
Expand Down
2 changes: 1 addition & 1 deletion .storybook/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"exclude": ["../**/*.spec.ts", "../**/*.mock.ts"],
"extends": "../tsconfig.base.json",
"include": ["../libs/client-components/src/**/*.ts", "../libs/client-diagnostics/src/**/*.ts"]
"include": ["../libs/client-components/src/lib/**/*.ts", "../libs/client-diagnostics/src/lib/**/*.ts"]
}
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,8 @@ Applications as well as generated documentation, testing reports, and a custom c
- [Backend Websocket](https://nx-ng-starter-documentation.web.app/assets/coverage/libs/backend-websocket/index.html)
- [Client](https://nx-ng-starter-documentation.web.app/assets/coverage/apps/client/index.html)
- [Client Chatbot](https://nx-ng-starter-documentation.web.app/assets/coverage/libs/client-chatbot/index.html)
- [Client Components](https://nx-ng-starter-documentation.web.app/assets/coverage/libs/client-components/index.html)
- [Client Core](https://nx-ng-starter-documentation.web.app/assets/coverage/libs/client-core/index.html)
- [Client Core Components](https://nx-ng-starter-documentation.web.app/assets/coverage/libs/client-core-components/index.html)
- [Client Diagnostics](https://nx-ng-starter-documentation.web.app/assets/coverage/libs/client-diagnostics/index.html)
- [Client Gql](https://nx-ng-starter-documentation.web.app/assets/coverage/libs/client-gql/index.html)
- [Client Material](https://nx-ng-starter-documentation.web.app/assets/coverage/libs/client-material/index.html)
Expand All @@ -119,7 +119,7 @@ Applications as well as generated documentation, testing reports, and a custom c
#### E2E report

- [Client E2E](https://nx-ng-starter-documentation.web.app/assets/cypress/client-e2e/mochawesome/mochawesome.html)
- [Client Components E2E](https://nx-ng-starter-documentation.web.app/assets/cypress/client-components-e2e/mochawesome/mochawesome.html)
- [Client Core Components E2E](https://nx-ng-starter-documentation.web.app/assets/cypress/client-core-components-e2e/mochawesome/mochawesome.html)
- [Client Diagnostics E2E](https://nx-ng-starter-documentation.web.app/assets/cypress/client-diagnostics-e2e/mochawesome/mochawesome.html)
- [Documentation E2E](https://nx-ng-starter-documentation.web.app/assets/cypress/documentation-e2e/mochawesome/mochawesome.html)
- [Elements E2E](https://nx-ng-starter-documentation.web.app/assets/cypress/elements-e2e/mochawesome/mochawesome.html)
Expand All @@ -137,9 +137,9 @@ Applications as well as generated documentation, testing reports, and a custom c
- [Client](https://nx-ng-starter-documentation.web.app/assets/changelog/apps/client-CHANGELOG.html)
- [Client E2E](https://nx-ng-starter-documentation.web.app/assets/changelog/apps/client-e2e-CHANGELOG.html)
- [Client Chatbot](https://nx-ng-starter-documentation.web.app/assets/changelog/libs/client-chatbot-CHANGELOG.html)
- [Client Components](https://nx-ng-starter-documentation.web.app/assets/changelog/libs/client-components-CHANGELOG.html)
- [Client Components E2E](https://nx-ng-starter-documentation.web.app/assets/changelog/libs/client-components-e2e-CHANGELOG.html)
- [Client Core](https://nx-ng-starter-documentation.web.app/assets/changelog/libs/client-core-CHANGELOG.html)
- [Client Core Components](https://nx-ng-starter-documentation.web.app/assets/changelog/libs/client-core-components-CHANGELOG.html)
- [Client Core Components E2E](https://nx-ng-starter-documentation.web.app/assets/changelog/libs/client-core-components-e2e-CHANGELOG.html)
- [Client Diagnostics](https://nx-ng-starter-documentation.web.app/assets/changelog/libs/client-diagnostics-CHANGELOG.html)
- [Client Diagnostics E2E](https://nx-ng-starter-documentation.web.app/assets/changelog/libs/client-diagnostics-e2e-CHANGELOG.html)
- [Client Gql](https://nx-ng-starter-documentation.web.app/assets/changelog/libs/client-gql-CHANGELOG.html)
Expand Down