Limit reset partitioning #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKoukiou
force-pushed
the
reset-part-limit
branch
5 times, most recently
from
96a966b
to
3b45086
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
KKoukiou
force-pushed
the
reset-part-limit
branch
6 times, most recently
from
7985961
to
51bdf80
Compare
KKoukiou
force-pushed
the
reset-part-limit
branch
5 times, most recently
from
fc34a72
to
b5b37ed
Compare
rvykydal
reviewed
May 22, 2024
rvykydal
reviewed
May 22, 2024
If the type matches, (MANUAL vs AUTOMATIC) and the devices also match then we can reuse the partitioning. Reset the partitioning always when entering the Installation Destination page.
Put this in a custom hook to increase component readability.
Identifying locked devices can be done prior to partitioning creation. After unlocking the devices we had to re-create the partitioning anyway. For implementing this change, adjust getLockedLUKSDevices helper to parse selectedDisks instead of the partitioning requests for identifying locked LUKS devices.
KKoukiou
force-pushed
the
reset-part-limit
branch
from
b5b37ed
to
f518755
Compare
|
Fixed issues and rebased. |
rvykydal
approved these changes
May 22, 2024
| const initialRequests = getInitialRequests(requests, mountPointConstraints); | ||
| setUnappliedRequests(initialRequests); | ||
|
|
||
| setIsFormValid(getRequestsValid(initialRequests, deviceData)); | ||
| }, [deviceData, setIsFormValid, partitioningDataPath, requests, mountPointConstraints]); | ||
| }, [deviceData, setIsFormValid, partitioning.path, requests, isLoadingPartitioning, unappliedRequests, mountPointConstraints]); |
There was a problem hiding this comment.
The partitioning.path dependency is listed here so that the hook is run in case applied partitioning changes, right?
There was a problem hiding this comment.
Correct, so if we have a new partitioning we need to recalculate the displayed requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.