Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use InconsistentParentSectorSize instead of InconsistentPVSectorSize #5547

Conversation

vojtechtrefny
Copy link
Contributor

Newest blivet will introduce a new exception for inconsistent sector sizes when creating new VGs and Stratis pools so we should use it.


This needs to wait for storaged-project/blivet#1222 to be merged and build, but the change is backwards compatible (catching InconsistentPVSectorSize will still work) so we don't need to build and release blivet and anaconda together.

@vojtechtrefny vojtechtrefny added the blocked Don't merge this pull request! label Apr 10, 2024
@github-actions github-actions bot added the f41 label Apr 10, 2024
Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. :)

@vojtechtrefny vojtechtrefny force-pushed the master_inconsistent-sector-size-exception branch from c0db54a to 7430abc Compare May 16, 2024 14:29
@vojtechtrefny vojtechtrefny removed the blocked Don't merge this pull request! label May 16, 2024
@vojtechtrefny
Copy link
Contributor Author

The blivet change is now available in rawhide so marking is no longer blocked.

Newest blivet will introduce a new exception for inconsistent
sector sizes when creating new VGs and Stratis pools so we should
use it.
@vojtechtrefny vojtechtrefny force-pushed the master_inconsistent-sector-size-exception branch from 7430abc to d36ea0e Compare June 4, 2024 07:18
@vojtechtrefny
Copy link
Contributor Author

/kickstart-test --testtype smoke

@vojtechtrefny vojtechtrefny merged commit f50d1bb into rhinstaller:master Jun 4, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 participants