feat: add update method as safer alternative to overwrite
#212
+176
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of deprecating it, I feel there is no harm to provide both options for different usage. We could just update the examples to prompt |
|
Yes, good idea. I've made that change. Sorry for the delay - this one got lost in my inbox |
benmccann
changed the title
update method as safer alternative to overwrite
|
Can you also update the dts? Thanks |
|
Also would be great to include a few tests for it. |
antfu
reviewed
Oct 4, 2022
antfu
changed the title
update method as safer alternative to overwriteupdate method as safer alternative to overwrite
antfu
approved these changes
Oct 5, 2022
jdalton
reviewed
Oct 9, 2022
| @@ -349,6 +349,12 @@ export default class MagicString { | |||
| } | |||
|
|
|||
| overwrite(start, end, content, options) { | |||
| options = options || {}; | |||
| options.overwrite = !options.contentOnly; | |||
There was a problem hiding this comment.
Modifying a user provided options object isn't great DX and unexpected.
There was a problem hiding this comment.
yes, you're right. I've sent a PR: #227
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In vitejs/vite#7397 we added
{ contentOnly: true }to every call tooverwritein order to fix vitejs/vite#7365. This could probably be the default. To quote @dummdidumm on that issue: