Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable @typescript-eslint/key-spacing rule #1708

Merged
merged 3 commits into from Feb 2, 2023

Conversation

aaneitchik
Copy link
Contributor

Because of a recent update to this rule in release v5.50.0, we have new ESLint errors that want code like this:

interface SomeInterface {
  someValue:
    | TypeA
    | TypeB;
}

to be formatted like this (weird spacing here in the example is intentional, that's what it corrects to):

interface SomeInterface {
  someValue:
                          | TypeA
    | TypeB;
}

because it seems the update to the rule doesn't work nicely with unions. While this behavior is probably unintentional, I don't think we need to check this rule anyway since we use Prettier, so we might just disable it.

@aaneitchik aaneitchik requested a review from a team February 1, 2023 13:35
@aaneitchik aaneitchik changed the title feat: configure @typescript-eslint/key-spacing rule feat: disable @typescript-eslint/key-spacing rule Feb 1, 2023
@aaneitchik aaneitchik requested a review from a team February 2, 2023 11:40
@griseau griseau merged commit 7a3f492 into master Feb 2, 2023
@griseau griseau deleted the feat/disable-key-spacing-rule branch February 2, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants