Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this WIP PR is to propose a new Tooltip API to be used across the app.
Why?
How?
aria-label
and other custom data propertiesAdditional Benefits:
modifiedClick
action that solves issues with the existing approach (multiple handlers can be called) and automatically adds adata-action
property that the tooltip renderer can parse to display modified click descriptionsThis PR illustrates this new approach in the SurfaceControlButton, NavigationEntry and Cell components. Currently, the implementation requires that the
data-tooltip
property be set so that it does not interfere with the existing system.