Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CSP error for Vega charts #4702

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix CSP error for Vega charts #4702

wants to merge 1 commit into from

Conversation

djbarnwal
Copy link
Member

Fix CSP errors using vega interpreter.
Also sets the web-local CSP policy to match with cloud.

@briangregoryholmes
Copy link
Contributor

briangregoryholmes commented Apr 24, 2024 •
edited

Not seeing alt-viz chart elements on Chrome or Safari, unfortunately. Charts work in the editor, though.

Screenshot 2024-04-24 at 9 37 50 AM

@djbarnwal
Copy link
Member Author

Looks like this is caused by an existing bug in Vega interpreter vega/vega#3632
String datetimes are not being handled by the interpreter. Created a PR in Vega vega/vega#3913

@ericpgreen2 ericpgreen2 added blocker A release blocker issue that should be resolved before a new release and removed blocker A release blocker issue that should be resolved before a new release labels Apr 29, 2024
@djbarnwal djbarnwal removed the request for review from briangregoryholmes May 7, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@djbarnwal @briangregoryholmes @ericpgreen2