Added option 'onlySelectVisibleSearchResultChildNodes' #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only visible child nodes should be selecting when selecting parent node while local search is active
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
==========================================
- Coverage 98.25% 98.17% -0.09%
==========================================
Files 27 27
Lines 1034 1039 +5
Branches 100 100
==========================================
+ Hits 1016 1020 +4
Misses 7 7
- Partials 11 12 +1
Continue to review full report at Codecov.
|
riophae
force-pushed
the
master
branch
2 times, most recently
from
86e8d8f
to
4a62c56
Compare
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
==========================================
- Coverage 98.25% 98.17% -0.09%
==========================================
Files 27 27
Lines 1034 1039 +5
Branches 100 100
==========================================
+ Hits 1016 1020 +4
Misses 7 7
- Partials 11 12 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When searching users expected that only visible nodes would be selected when selecting a parent node. Therefore I added an option named 'onlySelectVisibleSearchResultChildNodes' (because naming things is hard).
Example:
Selecting the parent node 'a' with onlySelectVisibleSearchResultChildNode=true will result in a selection of foo_a.