Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aria-label parameter #294

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fernandezcuesta
Copy link

Reporters like axe complain about treeselect component's input missing a11y parameters.
This adds an additional (optional) parameter to set the aria-label value for the input tag.

@codecov
Copy link

codecov bot commented Oct 2, 2019

Codecov Report

Merging #294 into master will decrease coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #294     +/-   ##
=========================================
- Coverage   97.88%   97.68%   -0.2%     
=========================================
  Files          27       27             
  Lines        1038     1038             
  Branches      104      104             
=========================================
- Hits         1016     1014      -2     
- Misses          7        9      +2     
  Partials       15       15
Impacted Files Coverage Δ
src/components/Input.vue 98.97% <ø> (ø) ⬆️
src/mixins/treeselectMixin.js 100% <ø> (ø) ⬆️
src/components/MenuPortal.vue 93.65% <0%> (-3.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62db434...abd690d. Read the comment docs.

@tomearly
Copy link

tomearly commented Jul 8, 2020

Is this something that can be added still?

@iampawan31
Copy link

Any idea when this PR will be merged? need this feature on the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants