Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: search bar uses all width in mobile #474

Merged
merged 3 commits into from
Apr 12, 2021

Conversation

BeeMargarida
Copy link
Contributor

@BeeMargarida BeeMargarida commented Apr 12, 2021

- -
Issue https://github.com/ripe-tech/ripe-pulse/issues/194
Dependencies
Decisions Like the design, in mobile mode the search occupies all width and appear above the container title.
Problems The new release 1.1.4 of vue test-utils introduced some regressions which caused the select to start failing. Issues about the regression: vuejs/vue-test-utils#1820 & vuejs/vue-test-utils#1808 (the PR that possibly caused this regression). vuejs/vue-test-utils#1824
Animated GIF image

@BeeMargarida BeeMargarida added bug Something isn't working regression Issue is related to a regression in behaviour labels Apr 12, 2021
@BeeMargarida BeeMargarida self-assigned this Apr 12, 2021
@vercel
Copy link

vercel bot commented Apr 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/platforme/ripe-components-vue/2TkfiRKTVPvnnmCZZYDyoNk1WuY7
✅ Preview: https://ripe-components-vue-git-ms-194-searchmobileregression-platforme.vercel.app

@BeeMargarida
Copy link
Contributor Author

Tests failing due to new release of vue-test-utils https://github.com/vuejs/vue-test-utils/releases

@gcandal
Copy link
Contributor

gcandal commented Apr 12, 2021

@BeeMargarida what commit caused the regression?

@BeeMargarida
Copy link
Contributor Author

@BeeMargarida what commit caused the regression?

The regression this PR fixes or the one that caused the tests to be failing (this is not a commit, its an update of a dependency)?

@BeeMargarida
Copy link
Contributor Author

@BeeMargarida what commit caused the regression?

The regression this PR fixes was caused by #449, where instead of using the search, the tooltip component now surrounds the search bar.

@gcandal gcandal assigned joamag and unassigned gcandal Apr 12, 2021
@joamag
Copy link
Contributor

joamag commented Apr 12, 2021

@BeeMargarida @gcandal I'm "debumping" packages to avoid the >= dependency and instead I'm merging this with build errors. Let's hope they fix their stuff soon. If not @BeeMargarida please open a new pull request just for that (bumping of packages) fix (in maybe 2-3 days)

@joamag joamag merged commit a8efefa into master Apr 12, 2021
@joamag joamag deleted the ms/194-search_mobile_regression branch April 12, 2021 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression Issue is related to a regression in behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants