feat: add OracleSet and OracleDelete transactions #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckniffen
reviewed
May 16, 2024
mvadari
reviewed
May 16, 2024
src/containers/shared/components/Transaction/OracleDelete/Simple.tsx
Outdated
Show resolved
Hide resolved
mvadari
reviewed
May 16, 2024
src/containers/shared/components/Transaction/OracleSet/Simple.tsx
Outdated
Show resolved
Hide resolved
mvadari
reviewed
May 16, 2024
mvadari
reviewed
May 16, 2024
| return ( | ||
| <div className="oracle-delete"> | ||
| { | ||
| // OracleDocumentID could be zero. |
There was a problem hiding this comment.
This can be a TODO for a future PR, but do you think it'd be useful to have info here about the oracle that's being deleted?
There was a problem hiding this comment.
People seem to ask about way we could filter tx by OracleDocumentID so I deemed that showing the ID might be important
mvadari
reviewed
May 16, 2024
src/containers/shared/components/Transaction/OracleDelete/Simple.tsx
Outdated
Show resolved
Hide resolved
mvadari
reviewed
May 16, 2024
src/containers/shared/components/Transaction/OracleDelete/TableDetail.tsx
Outdated
Show resolved
Hide resolved
mvadari
reviewed
May 16, 2024
src/containers/shared/components/Transaction/OracleDelete/TableDetail.tsx
Outdated
Show resolved
Hide resolved
mvadari
reviewed
May 16, 2024
src/containers/shared/components/Transaction/OracleSet/Simple.tsx
Outdated
Show resolved
Hide resolved
mvadari
reviewed
May 20, 2024
src/containers/shared/components/Transaction/OracleSet/parser.ts
Outdated
Show resolved
Hide resolved
mvadari
reviewed
May 20, 2024
mvadari
reviewed
May 20, 2024
mvadari
reviewed
May 22, 2024
| <span className="case-sensitive">{priceDataObj.assetPrice}</span> | ||
| </> | ||
| )} | ||
| {index < tx.priceDataSeries.length - 1 && ', '} |
mvadari
reviewed
May 23, 2024
mvadari
reviewed
May 23, 2024
src/containers/shared/components/Transaction/OracleSet/test/ConvertScalePrice.test.js
Outdated
Show resolved
Hide resolved
mvadari
reviewed
May 23, 2024
src/containers/shared/components/Transaction/OracleSet/test/OracleSetSimple.test.js
Outdated
Show resolved
Hide resolved
mvadari
reviewed
May 24, 2024
| @@ -0,0 +1,12 @@ | |||
| import { createSimpleWrapperFactory, expectSimpleRowText } from '../../test' | |||
There was a problem hiding this comment.
The tests that are testing React components should use .test.tsx as their file ending.
mvadari
reviewed
May 24, 2024
|
|
||
| // Convert scaled price (assetPrice) to original price using formula: | ||
| // originalPrice = assetPrice / 10**scale | ||
| // More details: https://github.com/XRPLF/XRPL-Standards/discussions/129 |
There was a problem hiding this comment.
This should link to the published standard, not the discussion: https://github.com/XRPLF/XRPL-Standards/tree/master/XLS-47d-PriceOracles
mvadari
reviewed
May 24, 2024
|
|
||
| describe('convertScaledPrice', () => { | ||
| it('should convert scaled price to original price correctly using scale factor', () => { | ||
| // scaled price: 5083 |
There was a problem hiding this comment.
If you want this to be easier to read (and avoid the need for a comment), you can convert the numbers to hex in the test itself instead of just using the hex
mvadari
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Title said it all.
Context of Change
PriceOracle amendment:
XRPLF/XRPL-Standards#129
Type of Change
Before / After
OracleSet transaction page:
OracleDelete transaction page:
Table Detail view: