add xls-33d-mpts #71
Open
add xls-33d-mpts #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add MPTs to landing page
Add a basic landing page for reference topics.
Remove clawback, add multi-purpose tokens
Add mptokenissuancecreate.md
mptokenissuancedestroy.md and mptokenissuanceset.md
Adding a landing page
Add landing page to TOC
Updates based on final updates to standard XLS-0033d
Updates based on revisions to the XLS-0033d standard.
Fix table typos
Format/typo fixes.
minor fixes to sidebar
nope, escape char didn't work
Update clawback transaction with new MPTokenHolder field.
Add clawback reference page.
Add Clawback reference.
Add MPT fields.
fix copy/paste error and internal links
Add Ledger Entry page.
Add ledger-entry.md
Move ledger_entry under Requests
Remove stray dash.
shawnxie999
reviewed
Feb 16, 2024
There was a problem hiding this comment.
actually there is no more account_mpts api
If one wishes to find the mptissuance or mptoken that an account owns, they can just use account_objects. Though one small addition is that if the object type is MPTokenIssuance, then there is a synthetic mpt_issuance_id field.
see here https://github.com/XRPLF/XRPL-Standards/tree/master/XLS-0033d-multi-purpose-tokens#632-object
docs/xls-33d-multi-purpose-tokens/reference/mptokenissuancecreate.md
Outdated
Show resolved
Hide resolved
shawnxie999
reviewed
Feb 16, 2024
docs/xls-33d-multi-purpose-tokens/reference/mptokenissuancecreate.md
Outdated
Show resolved
Hide resolved
Changes per review by shawnxie999
Change the OutstandingAmount in the sample JSON to "3e8" to make it clear this is a hexadecimal string rather than a decimal value.
Add a section to cover the caveat regarding decimal versus hexadecimal values in MPT fields.
Fixing a mistake from a prior edit.
shawnxie999
reviewed
Mar 22, 2024
There was a problem hiding this comment.
There no such API called mpts_by_issuer or account_mpts. The only API introduced in this feature is mpt_holders, which is clio-only API. The spec has been updated, and there has been some additions to the details.
Edit: ledger_entry has been updated and some synthetic fields in some APIs as well
shawnxie999
reviewed
Mar 22, 2024
shawnxie999
reviewed
Mar 22, 2024
shawnxie999
reviewed
Mar 22, 2024
mpts_by_issuer is no longer part of the spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-purpose Tokens documentation.