-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(storage): bump object_store_read_attempt_timeout_ms
from 8s
to 16s
#16719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwannoel
force-pushed
the
kwannoel/bump-timeout-to-16s
branch
from
May 13, 2024 07:42
eb0af04
to
8c48b2e
Compare
kwannoel
force-pushed
the
kwannoel/bump-timeout-to-16s
branch
from
May 16, 2024 04:22
044b3a1
to
b308801
Compare
kwannoel
force-pushed
the
kwannoel/bump-timeout-to-16s
branch
from
May 16, 2024 05:27
b308801
to
3bdb3fb
Compare
kwannoel
added
the
need-cherry-pick-release-1.9
Open a cherry-pick PR to branch release-1.8 after the current PR is merged
label
May 16, 2024
lmatz
approved these changes
May 16, 2024
Do we still need this PR if we have #16782? I thought we are going to increase the timeout for CI test only. |
I merged the wrong PR. Let me revert it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci/main-cron/skip-ci
ci/run-backfill-tests
ci/run-build
ci/run-build-other
ci/run-main-cron
need-cherry-pick-release-1.9
Open a cherry-pick PR to branch release-1.8 after the current PR is merged
type/chore
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
8s
is too short as a default. The object store will timeout.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.