Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make pg meta backend by default in docker compose #16724

Merged
merged 2 commits into from
May 14, 2024

Conversation

yezizp2012
Copy link
Contributor

@yezizp2012 yezizp2012 commented May 13, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title.

  1. I left docker-compose-with-hdfs.yml unchanged, because it used a customized image RisingWave_1.6.1_HDFS_2.7-x86_64.
  2. The two new yamls are just renamed from those default ones.
  3. After v1.9.0, we can change all affected yamls to use it instead.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Contributor

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Contributor

@lmatz lmatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@yezizp2012 yezizp2012 added the need-cherry-pick-release-1.9 Open a cherry-pick PR to branch release-1.8 after the current PR is merged label May 14, 2024
@yezizp2012 yezizp2012 enabled auto-merge May 14, 2024 06:25
@yezizp2012 yezizp2012 added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit 76278e9 May 14, 2024
12 of 13 checks passed
@yezizp2012 yezizp2012 deleted the feat/default-pg-backend-docker-compose branch May 14, 2024 06:54
github-merge-queue bot pushed a commit that referenced this pull request May 14, 2024
)

Co-authored-by: August <pin@singularity-data.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-cherry-pick-release-1.9 Open a cherry-pick PR to branch release-1.8 after the current PR is merged type/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants