fix: mysql cdc read timezone and correct mysql test image #16732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuhao-su
changed the title
yuhao-su
changed the title
StrikeW
reviewed
May 14, 2024
java/connector-node/risingwave-connector-service/src/main/resources/mysql.properties
Show resolved
Hide resolved
yuhao-su
commented
May 16, 2024
Comment on lines
+8
to
+12
| system ok | ||
| mysql -e " | ||
| SET GLOBAL time_zone = '+01:00'; | ||
| " | ||
|
|
There was a problem hiding this comment.
This will actually affect other potential mysql test running in parallel, do you have any suggestion on addressing this? @xxchan
There was a problem hiding this comment.
If really needed, you can write the old value to some tmp file, and restore it at the end.
I think many source tests can only be run in serial...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
The bug will affect Mysql CDC if the MySQL table time zone is not UTC
The default param
connectionTimeZonewill be server. That mean it will convert time column by the session timezone param. If set to '+00:00', debezium will assume the server timezone is '+00:00'Since there will be corner cases for
connectionTimeZone=SERVER, we will useconnectionTimeZone=+00:00andforceConnectionTimeZoneToSession=trueclose #16496
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.