Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): workaround for toolchain upgrade #5980

Merged
merged 6 commits into from
Oct 26, 2022

Conversation

BugenZhao
Copy link
Member

Signed-off-by: Bugen Zhao 2 i@bugenzhao.com

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

This PR mainly removes some unnecessary generics in the storage code.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #5980 (999a4a1) into main (2653489) will decrease coverage by 0.05%.
The diff coverage is 66.70%.

@@            Coverage Diff             @@
##             main    #5980      +/-   ##
==========================================
- Coverage   74.67%   74.62%   -0.06%     
==========================================
  Files         928      930       +2     
  Lines      147900   148422     +522     
==========================================
+ Hits       110450   110759     +309     
- Misses      37450    37663     +213     
Flag Coverage Δ
rust 74.62% <66.70%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/session_config/mod.rs 30.15% <0.00%> (-0.31%) ⬇️
src/compute/src/rpc/service/exchange_service.rs 0.00% <ø> (ø)
src/compute/src/rpc/service/stream_service.rs 0.00% <0.00%> (ø)
src/ctl/src/cmd_impl/hummock/list_kv.rs 0.00% <0.00%> (ø)
src/ctl/src/cmd_impl/hummock/sst_dump.rs 0.00% <0.00%> (ø)
src/expr/src/vector_op/agg/aggregator.rs 55.05% <0.00%> (-0.32%) ⬇️
src/frontend/src/expr/agg_call.rs 63.47% <0.00%> (-1.13%) ⬇️
src/frontend/src/handler/explain.rs 55.10% <0.00%> (-0.57%) ⬇️
src/frontend/src/handler/variable.rs 0.00% <0.00%> (ø)
src/frontend/src/optimizer/plan_node/stream.rs 0.00% <0.00%> (ø)
... and 105 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@skyzh
Copy link
Contributor

skyzh commented Oct 24, 2022

/hold, let's remove performance-related workarounds before starting review.

@skyzh
Copy link
Contributor

skyzh commented Oct 24, 2022

specifically unsafe_boxed_static_future, I feel we won't wait long before the upstream resolves this issue.

Signed-off-by: Bugen Zhao <i@bugenzhao.com>

remove redundant code

Signed-off-by: Bugen Zhao <i@bugenzhao.com>

cleanup

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@skyzh skyzh force-pushed the bz2/prepare-toolchain-update branch from d62294c to 702edef Compare October 25, 2022 03:01
@skyzh skyzh marked this pull request as ready for review October 25, 2022 03:01
@skyzh
Copy link
Contributor

skyzh commented Oct 25, 2022

cc @Li0k @wenym1 @hzxa21 PTAL thanks. There should be no performance regression for this PR.

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@skyzh
Copy link
Contributor

skyzh commented Oct 25, 2022

write anytime broken by a wrong refactor in merge iterator. will fix tomorrow 🥵

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@skyzh
Copy link
Contributor

skyzh commented Oct 26, 2022

Really ready for review

@skyzh skyzh requested a review from xxchan October 26, 2022 03:16
Copy link
Contributor

@Li0k Li0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @wenym1 @hzxa21 PTAL

@skyzh skyzh added the mergify/can-merge Indicates that the PR can be added to the merge queue label Oct 26, 2022
@mergify mergify bot merged commit 23ca731 into main Oct 26, 2022
@mergify mergify bot deleted the bz2/prepare-toolchain-update branch October 26, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue type/chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants