Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #110

Closed
wants to merge 1 commit into from
Closed

Update dependencies #110

wants to merge 1 commit into from

Conversation

LeviPesin
Copy link

Fixes #107

@guipace
Copy link

guipace commented Feb 23, 2023

@ritz078, Any chance we can get this reviewed and merged in to fix dependency security issues? I would do it myself, but a bit hesitant since the build checks didn't run on this branch and I'm not sure why.

@ritz078
Copy link
Owner

ritz078 commented Feb 23, 2023

@guipace Are the tests passing locally ?

@LeviPesin
Copy link
Author

I think the tests didn't run because it is the first time I'm contributing to this repository (so the workflow should be approved by maintainer).

@guipace
Copy link

guipace commented Feb 24, 2023

@guipace Are the tests passing locally ?

I'm getting all sorts of errors trying to run yarn install. I'm not going to touch this without knowing the context or having worked on it before. I was trying to resolve a dependabot alert on a repo of mine that depends on this plugin.

image

image

@LeviPesin
Copy link
Author

Maybe we can update only pacote then? Seems like most problems come from the fact it's outdated.

@ritz078 ritz078 mentioned this pull request Feb 24, 2023
@ritz078
Copy link
Owner

ritz078 commented Feb 24, 2023

This PR breaks the module. Does #114 fix your issue ?

It shows moderate issues in ava which is a dev dependency but all other issues are gone. Updating ava is going to take a bit longer.

@LeviPesin
Copy link
Author

Seems to resolve, thank you!

@LeviPesin LeviPesin closed this Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependencies
3 participants