Support multiple locales concurrent #368
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit extends the plugin to support loading and using mutliple locales at the same time. All strings are stored with their language code. The plugins gets a new `lang` setting denoting the default locale. For each HTML tag, the plugin will lookup `lang` attribute from the tag, the configured default lang, or fallback to english. It will use the `strings` object directly, if no lang key is found at all, therefore it supports loading and running with older or custom locale files that are directly assigning strings.
|
@rmm5t Anything more needed here to get this merged? Newer Rails version have some of NPM integration and a few more people asked me to provide a npm package from rails-timeago, but I am always kindly redirecting them to your project. Some were missing the locale support... |
melloware
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the revised patch from rails-timeago as mentioned in #173.
I've added a few tests to test locale detection and selection.