build: migrate to ngx-deploy-npm v8 #1278
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dianjuar
commented
Jan 22, 2024
Comment on lines
-49
to
+56
| "buildTarget": "production" | ||
| "distFolderPath": "dist/packages/avatar" | ||
| }, | ||
| "dependsOn": ["pre-npm-deploy-build-production"] | ||
| }, | ||
| "pre-npm-deploy-build-production": { | ||
| "executor": "nx:run-commands", | ||
| "options": { | ||
| "command": "nx run avatar:build:production" |
There was a problem hiding this comment.
I see that the default mode of the build is production, so we can drop the new target creation to build in production mode to make it more streamlined.
It would look like the following:
"npm-deploy": {
"executor": "ngx-deploy-npm:deploy",
"options": {
"access": "public",
"buildTarget": "production"
"distFolderPath": "dist/packages/badge"
},
"dependsOn": ["build"]
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ngx-deploy-npm introduces some breaking changes on version 8.0.0.
More information about the changes and their motivation can be found on this blog post