Issue checkstyle#12681: removes serializable from violation

rnveach · Feb 3, 2023 · e7b3c92 · e7b3c92
1 parent a144e7f
commit e7b3c92
Showing 1 changed file with 3 additions and 16 deletions.
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/api/Violation.java b/src/main/java/com/puppycrawl/tools/checkstyle/api/Violation.java
@@ -19,7 +19,6 @@
 
 package com.puppycrawl.tools.checkstyle.api;
 
-import java.io.Serializable;
 import java.text.MessageFormat;
 import java.util.Arrays;
 import java.util.Locale;
@@ -32,16 +31,12 @@
  * message.properties files. The underlying implementation uses
  * java.text.MessageFormat.
  *
- * @noinspection SerializableHasSerializationMethods, ClassWithTooManyConstructors
- * @noinspectionreason SerializableHasSerializationMethods - we do not serialize this class
+ * @noinspection ClassWithTooManyConstructors
  * @noinspectionreason ClassWithTooManyConstructors - immutable nature of class requires a
  *      bunch of constructors
  */
 public final class Violation
-    implements Comparable<Violation>, Serializable {
-
-    /** A unique serial version identifier. */
-    private static final long serialVersionUID = 5675176836184862150L;
+    implements Comparable<Violation> {
 
     /** The default severity level if one is not specified. */
     private static final SeverityLevel DEFAULT_SEVERITY = SeverityLevel.ERROR;
@@ -64,15 +59,7 @@ public final class Violation
     /** Key for the violation format. **/
     private final String key;
 
-    /**
-     * Arguments for MessageFormat.
-     *
-     * @noinspection NonSerializableFieldInSerializableClass
-     * @noinspectionreason NonSerializableFieldInSerializableClass - usage of
-     *      'Serializable' for this api class
-     *      is considered as mistake now, but we do not break api without
-     *      good reason
-     */
+    /** Arguments for MessageFormat. */
     private final Object[] args;
 
     /** Name of the resource bundle to get violations from. **/