TypeScript 5.3 (#2617)

- Bumps `typescript` and `ts-expose-internals` to v5.3.3
- Removes the test diagnostic for `noSuperProperty` as the compiler
catches this now (microsoft/TypeScript/pull/54056)
- Make 1:1 changes for methods and fields
- Handles the `NoSubstitutionTemplateLiteral` node from
microsoft/TypeScript/pull/55930

Please take a look at the module resolution change. I'm not sure if this
will have downstream effects that I couldn't catch in testing.

Closes #2610

---------

Co-authored-by: Osyris <osyrisrblx@gmail.com>

package.json

@@ -55,7 +55,7 @@
 		"fs-extra": "^11.2.0",
 		"kleur": "^4.1.5",
 		"resolve": "^1.22.6",
-		"typescript": "=5.2.2",
+		"typescript": "=5.3.3",
 		"yargs": "^17.7.2"
 	},
 	"devDependencies": {
@@ -64,7 +64,7 @@
 		"@types/node": "^20.11.17",
 		"@types/prompts": "^2.4.9",
 		"@types/resolve": "^1.20.6",
-		"@types/ts-expose-internals": "npm:ts-expose-internals@=5.2.2",
+		"@types/ts-expose-internals": "npm:ts-expose-internals@=5.3.3",
 		"@types/yargs": "^17.0.32",
 		"@typescript-eslint/eslint-plugin": "^7.0.1",
 		"@typescript-eslint/parser": "^7.0.1",

src/Project/transformers/builtin/transformPaths.ts

@@ -199,7 +199,7 @@ export const transformPaths = (context: ts.TransformationContext) => (sourceFile
 		return ts.factory.updateImportTypeNode(
 			node,
 			fileArgument,
-			node.assertions,
+			node.attributes,
 			node.qualifier,
 			node.typeArguments,
 			node.isTypeOf,
@@ -277,7 +277,7 @@ export const transformPaths = (context: ts.TransformationContext) => (sourceFile
 				node.isTypeOnly,
 				node.exportClause,
 				fileLiteral,
-				node.assertClause,
+				node.attributes,
 			);
 		}
 
@@ -289,7 +289,7 @@ export const transformPaths = (context: ts.TransformationContext) => (sourceFile
 					node.isTypeOnly,
 					node.exportClause,
 					fileLiteral,
-					node.assertClause,
+					node.attributes,
 				)
 			: undefined;
 	}

src/Shared/diagnostics.ts

@@ -143,7 +143,6 @@ export const errors = {
 	noGlobalThis: error("`globalThis` is not supported!"),
 	noArguments: error("`arguments` is not supported!"),
 	noPrototype: error("`prototype` is not supported!"),
-	noSuperProperty: error("super properties are not supported!"),
 	noRobloxSymbolInstanceof: error(
 		"The `instanceof` operator can only be used on roblox-ts classes!",
 		suggestion('Use `typeIs(myThing, "TypeToCheck") instead'),

src/TSTransformer/nodes/expressions/transformPropertyAccessExpression.ts

@@ -1,7 +1,5 @@
 import luau from "@roblox-ts/luau-ast";
-import { errors } from "Shared/diagnostics";
 import { TransformState } from "TSTransformer";
-import { DiagnosticService } from "TSTransformer/classes/DiagnosticService";
 import { transformOptionalChain } from "TSTransformer/nodes/transformOptionalChain";
 import { addIndexDiagnostics } from "TSTransformer/util/addIndexDiagnostics";
 import { convertToIndexableExpression } from "TSTransformer/util/convertToIndexableExpression";
@@ -36,10 +34,6 @@ export function transformPropertyAccessExpressionInner(
 }
 
 export function transformPropertyAccessExpression(state: TransformState, node: ts.PropertyAccessExpression) {
-	if (ts.isSuperProperty(node)) {
-		DiagnosticService.addDiagnostic(errors.noSuperProperty(node));
-	}
-
 	const constantValue = getConstantValueLiteral(state, node);
 	if (constantValue) {
 		return constantValue;

src/TSTransformer/util/binding/objectAccessor.ts

@@ -23,7 +23,7 @@ export const objectAccessor = (
 			expression: parentId,
 			index: addOneIfArrayType(state, type, transformExpression(state, name.expression)),
 		});
-	} else if (ts.isNumericLiteral(name) || ts.isStringLiteral(name)) {
+	} else if (ts.isNumericLiteral(name) || ts.isStringLiteral(name) || ts.isNoSubstitutionTemplateLiteral(name)) {
 		return luau.create(luau.SyntaxKind.ComputedIndexExpression, {
 			expression: parentId,
 			index: transformExpression(state, name),

src/TSTransformer/util/getSourceFileFromModuleSpecifier.ts

@@ -11,9 +11,9 @@ export function getSourceFileFromModuleSpecifier(state: TransformState, moduleSp
 		if (declaration && ts.isModuleDeclaration(declaration) && ts.isStringLiteralLike(declaration.name)) {
 			const sourceFile = moduleSpecifier.getSourceFile();
 			const mode = ts.getModeForUsageLocation(sourceFile, declaration.name);
-			const resolvedModuleInfo = ts.getResolvedModule(sourceFile, declaration.name.text, mode);
-			if (resolvedModuleInfo) {
-				return state.program.getSourceFile(resolvedModuleInfo.resolvedFileName);
+			const resolvedModuleInfo = state.program.getResolvedModule(sourceFile, declaration.name.text, mode);
+			if (resolvedModuleInfo && resolvedModuleInfo.resolvedModule) {
+				return state.program.getSourceFile(resolvedModuleInfo.resolvedModule.resolvedFileName);
 			}
 		}
 

tests/src/tests/object.spec.ts

@@ -334,6 +334,19 @@ export = () => {
 		expect(c[9]).to.equal(1);
 	});
 
+	it("should support template literal indexes without substitution", () => {
+		const obj = {
+			data: 55,
+			thing: "hello"
+		}
+
+		const a = obj[`data`]
+		const b = obj[`thing`]
+
+		expect(a).to.equal(55)
+		expect(b).to.equal("hello")
+	})
+
 	it("should support composing objects with methods and callbacks", () => {
 		interface Numerable {
 			n: number;