Update examples to use ActivityController#close #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use `Robolectric.buildActivity`/`ActivityController#setup` with `try-with-resources` to demonstrate test needing to call `ActivityController#close` * Replace AssertJ(?) assertion with basic JUnit `assertEquals` * Use `findViewById` rather than public view fields
|
Hi @hoisie , could you help to review this PR? Thanks. |
|
Hi @hoisie , could you help to review this PR? IMO, it can provide more precise usage of |
hoisie
approved these changes
Jul 30, 2022
|
@seadowg Could you help to update example in Robolectric main repository README? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes robolectric/robolectric#7041
As discussed in the issue, the examples needed to be updated so that it's clear that
close()should be called. We could also add a note to Best Practices around this, but I wanted to start with making sure the code examples are up to date.