Remove deprecated methods in ShadowDisplay
#8840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes all the deprecated methods in `ShadowDisplay`. The only deprecated method I kept is `getRefreshRate()`, otherwise the `setRefreshRate()` method has no effect anymore. Maybe we should deprecate it for removal in a future release?
utzcoz
reviewed
Feb 16, 2024
robolectric/src/test/java/org/robolectric/shadows/ShadowDisplayTest.java
Show resolved
Hide resolved
hoisie
approved these changes
Feb 16, 2024
|
@MGaetan89 Thanks for your contribution. You can rebase you previous PR, and we can continue the discuss in that PR page. |
|
@hoisie @MGaetan89 Maybe we can create a new article on |
MGaetan89
deleted the
feature/remove_shadowdisplay_deprecated_methods
branch
Good idea! Maybe we can update the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #8810, this PR removes all the deprecated methods in
ShadowDisplay. The only deprecated method I kept isgetRefreshRate(), otherwise thesetRefreshRate()method has no effect anymore. Maybe we should deprecate it for removal in a future release?