Stop returning the resources sdk level in RuntimeEnvironment.getQualifiers #9070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
piper_632391415
branch
from
9efa65a
to
807b0ca
Compare
…fiers Previously, the Build.VERSION.RESOURCES_SDK_INT constant was returned as a suffix in the call to RuntimeEnvironment.getQualifiers. For example, it could contain the suffix 'v24'. There was not much value in returning the SDK level. It was unused, except for RuntimeEnvironment.setQualifiers checking that the sdk level matched RuntimeEnvironment.getApiLevel(). It is not possible to set the SDK level using RuntimeEnvironment.setQualifiers. RESOURCES_SDK_INT causes problems in the current Android V SDK, as it is higher than the SDK level. This causes RuntimeEnvironment.setQualifiers(RuntimeEnvironment.getQualifiers) to throw an Exception. Because this API level is unused, it can be removed from the result of RuntimeEnvironment.getQualifiers. PiperOrigin-RevId: 632580756
copybara-service
bot
force-pushed
the
piper_632391415
branch
from
807b0ca
to
8e8e283
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop returning the resources sdk level in RuntimeEnvironment.getQualifiers
Previously, the Build.VERSION.RESOURCES_SDK_INT constant was returned as a
suffix in the call to RuntimeEnvironment.getQualifiers. For example, it could
contain the suffix 'v24'.
There was not much value in returning the SDK level. It was unused, except for
RuntimeEnvironment.setQualifiers checking that the sdk level matched
RuntimeEnvironment.getApiLevel(). It is not possible to set the SDK level using
RuntimeEnvironment.setQualifiers.
RESOURCES_SDK_INT causes problems in the current Android V SDK, as it is higher
than the SDK level. This causes
RuntimeEnvironment.setQualifiers(RuntimeEnvironment.getQualifiers) to throw an
Exception.
Because this API level is unused, it can be removed from the result of
RuntimeEnvironment.getQualifiers.