Screenshot changes to support more image types #5108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nshots in formats other than jpg;
… for non-jpg image formats;
|
@pekkaklarck looking at the Acceptance test results, the root error appears to be, "Make sure tests are run with a physical or virtual display." Which I experienced on my local env when running tests originally, had to uncomment the "WaylandEnable=false" line inside /etc/gdm3/custom.conf (something about recent changes in Unbuntu). |
|
It's pretty much impossible to review the PR because the whole Screenshot.py file has changed. Have you possibly changed line endings? |
|
@pekkaklarck Sorry about the CRLFs. I got those mixed up in my IDE. Looks to be much cleaner now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modification of the Screenshot/Taker classes to support other image formats than just "jpg"
Implemented support for: jpg, png, tiff, and bmp; although other formats can be supported by extending Screenshot.IMAGE_FORMATS;
Extended test cases to prove out the support for non-jpg types;