Refactor

robvanderleek · May 4, 2024 · 3ae0ac0 · 3ae0ac0
1 parent f3f8d44
commit 3ae0ac0
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 11 deletions.
diff --git a/src/probot.ts b/src/probot.ts
@@ -60,10 +60,15 @@ export default (app: Probot, {getRouter}: ApplicationFunctionOptions) => {
             owner: ctx.payload.repository.owner.login,
             repo: ctx.payload.repository.name
         }
-        const dbService = new MongoDbService();
-        app.log(`Inserting event into database: ${JSON.stringify(webhookEvent)}`);
-        await dbService.storeEvent(webhookEvent);
-        dbService.disconnect();
+        const connectionString = process.env.CREATE_ISSUE_BRANCH_MONGODB;
+        if (!connectionString) {
+            app.log('Environment variable CREATE_ISSUE_BRANCH_MONGODB not set, skipping database insert')
+        } else {
+            const dbService = new MongoDbService(connectionString);
+            app.log(`Inserting event into database: ${JSON.stringify(webhookEvent)}`);
+            await dbService.storeEvent(webhookEvent);
+            dbService.disconnect();
+        }
     });
 }
 

diff --git a/src/services/MongoDbService.ts b/src/services/MongoDbService.ts
@@ -2,19 +2,19 @@ import {MongoClient, MongoClientOptions} from "mongodb";
 import {WebhookEvent} from "../entities/WebhookEvent";
 
 export class MongoDbService {
+    connectionString: string;
     client?: MongoClient = undefined;
 
+    constructor(connectionString: string) {
+        this.connectionString = connectionString;
+    }
+
     async getDatabase() {
         if (!this.client) {
             const options: MongoClientOptions = {
                 authSource: 'admin',
             };
-            const connectionString = process.env.CREATE_ISSUE_BRANCH_MONGODB;
-            if (!connectionString) {
-                throw new Error('Environment variable CREATE_ISSUE_BRANCH_MONGODB not set');
-            } else {
-                this.client = await MongoClient.connect(connectionString, options);
-            }
+            this.client = await MongoClient.connect(this.connectionString, options);
         }
         return this.client.db('create-issue-branch');
     }
@@ -28,5 +28,4 @@ export class MongoDbService {
     disconnect() {
         this.client?.close();
     }
-
 }