Initial proposal for Population Variance #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a proposed implementation for roc-lang#36 I am still a bit confused with the edge case that on main, if I provide `[]` instead of a List with numbers, I am not getting the expected `Err NotEnoughItems` and I don't understand why. Also, trying to run `roc test` crashes, as reported on roc-lang/roc#5482
|
Thanks @fdbeirao! Your PR was already excellent but I tried to make some small improvements because we advertise our examples as "the gold standard" 😄 Let me know if you disagree with any of my changes. We can merge this once roc-lang/roc#5482 has been fixed and a README has been added. |
fdbeirao
commented
May 31, 2023
|
Thank you for your commits @Anton-4, and for adding the output expectation tests. 🙏 |
|
This doesn't look blocked any longer. @fdbeirao are you interested in resolving up the merge conflicts and updating to latest main? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed implementation for #36
I am still a bit confused with the edge case that on main, if I provide
[]instead of a List with numbers, I am not getting the expectedErr NotEnoughItemsand I don't understand why.Also, trying to run
roc test(after uncommenting theexpect) crashes, as reported on roc-lang/roc#5482Current output of running
roc run --linker=legacyσ² = 5032.13888888889