Print special float values as Num.nanF64, etc #6755
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #6709. I might need a little bit of help on this one.
My understanding of rust macros is limited - I suspect the
f64_helper!
andf32_helper!
macros could be elided. I was trying to avoid adding a trait just for dispatching on the number printing function at the end.I also think my usage of
Expr::Num("Num.nanF64")
is wrong since we aren't actually implementing these as literals - there must be another AST node type for getting something from a module?There are a few pieces of documentation in
Num.roc
that could be updated to reflect these changes.Finally, I wasn't sure if there was any runtime (zig) code for printing numbers as strings that we also want to consider? (Sorry, my understanding of the system as a whole is limited at this stage).