Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a shuffle feature #1853

Open
wants to merge 4 commits into
base: core-separation
Choose a base branch
from

Conversation

ayabusa
Copy link

@ayabusa ayabusa commented Aug 22, 2023

Why adding a shuffle feature ?

The first time I installed Lively I wanted to automatically switch to new random wallpaper after some time, but I could not. So I decided to add this feature myself as I feel it's a crucial one. For the user it adds a new button which open a little menu where he can choose to enable/disable the feature and change the delay (see screenshot). After that, the user can do something else on his computer and the wallpaper will automatically change after some time, which I find really convenient :)

image

From a technical aspect.

The core of the shuffle loop is located in the TimerService.cs file, the loop is created at the begining, if the setting DoRandomWallpaper is set to true and using the TimeToChangeWallpaper setting as the intervall. Once Lively is launched the loop can be enabled/disabled/modified using the UI (ShuffleView and ShuffleViewModel).

That's it, I hope you will accept this feature as I feel it is a crucial element for such a program :)

@CLAassistant
Copy link

CLAassistant commented Aug 22, 2023

CLA assistant check
All committers have signed the CLA.

@rocksdanister
Copy link
Owner

Good work!

Normally for pull requests it is recommended to start an issue/discussion to plan how to implement; I'll keep this one open..
Will take a look when I am free.. currently busy making a weather app ^_^

@ayabusa
Copy link
Author

ayabusa commented Aug 30, 2023

Thanks for your reply,
And sorry for not having started an issue/discussion, I will know for next time !
I’m available if you need anything that would help the implementation of this feature :D

@0xDeadcell
Copy link

Any update on getting this merged? I'd love to see this feature.

@rocksdanister
Copy link
Owner

Wallpaper stealing focus on start was one of the reason playlist never got implemented, now that it is fixed can look into adding this feature next update.

For the time being you can write scripts to implement playlist:
https://github.com/rocksdanister/lively/wiki/Command-Line-Controls#python

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants