Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new functions this_line, this_file, this_counter #115

Open
wants to merge 9 commits into
base: remake-4-3
Choose a base branch
from

Conversation

bstarynk
Copy link

@bstarynk bstarynk commented Jan 8, 2021

This patch add new functions :

  • $(this_line) - inspired by __LINE__ in C and expanded to the current file name (e.g. Makefile)
  • $(this_file) - inspired by __FILE__ in C and expanded to the current line number (e.g. 123 if appearing in line 123 of your GNUmakefile
  • $(this_counter), inspired by __COUNTER__ from GCC preprocessor

The documentation is wrong and needs some fix.

Also, the GNUremakefile is also considered as a name.

Copy link
Owner

@rocky rocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment. I am assuming a invetent deletion of a line.

Otherwise, this is great! Many thanks!

@end table

@node Conditional Functions, Foreach Function, File Name Functions, Functions
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting an in build because this @node line is missing:

make
Making all in lib
make[1]: Entering directory '/tmp/remake/lib'


make.texi:12429: @xref reference to nonexistent node `Conditional Functions'
make.texi:12435: @xref reference to nonexistent node `Conditional Functions'
make.texi:12442: @xref reference to nonexistent node `Conditional Functions'
make.texi:7030: @menu reference to nonexistent node `Conditional Functions'
make.texi:278: @detailmenu reference to nonexistent node `Conditional Functions'
make.texi:7455: Next reference to nonexistent `Conditional Functions'
make.texi:7708: Prev reference to nonexistent `Conditional Functions'
Makefile:918: *** [make.info] error 1


Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you help (perhaps by patching the pull request). I am not familiar witrh texinfo. But you could use the C code and improve/correct the documentation. Thanks. Basile Starynkevitch

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok - #116 started. (I thought when you open a PR there's a button that allows maintainers to add more commits. I didn't see that here so a new PR was started).

I don't see though that the this_ functions do anything. See that PR for details.

@rocky rocky force-pushed the remake-4-3 branch 5 times, most recently from 269a076 to 3048790 Compare January 22, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants