Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests broken and false positive #26

Open
jehy opened this issue Jan 30, 2020 · 1 comment
Open

Tests broken and false positive #26

jehy opened this issue Jan 30, 2020 · 1 comment

Comments

@jehy
Copy link

jehy commented Jan 30, 2020

Unit tests on project only pass if you use yarn with yarn.lock.

If you try rm ./node_modules -rf && npm i && npm test - then tests fail.

On production, yarn.lock in package is not used even by yarn itself - it only uses top level lock file - and it means that those test cases will fail on production code.

We can either use shrinkwrap-json to ensure that project's transitive dependencies with be installed with versions we want - or remove confusing yarn lock and fix project to work fine with current deps.

@ljharb
Copy link
Collaborator

ljharb commented Jan 30, 2020

I'd prefer to remove all lockfiles, and use npm instead of yarn, to mirror the majority usage of our users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants