added npm-shrinkwrap #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Jan 30, 2020
|
Yup. But right now deps are broken. We need either to fix them or freeze them. And fixing will be really hard - and I suppose impossible if you want to keep compatibility with node 4. |
|
Hard or not, fixing them without breaking compat is the right thing to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #26
Added shrinkwrap file - with it, you can just run npm install and npm test. Also, transitive dependencies will be respected and same fails as on tests won't happen on production.
The only drawback is that it user will have many dependencies. This is a hack which should be avoided but it is better that having code that works wrong.