Use create-jest-runner. #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed own worker pool implementation.
|
Note quite sure why tests on node 4 are failing. I don't see how I changed something that affects expect. |
|
Jest aggressively drops support for older nodes, including node 4, so it probably won’t work there. |
|
This PR looks great, may be it's time to merge this PR, drop node8- support, use latest mocha, get rid of babel and release a new major version? Anyone who still uses old node version will still be able to use older runner branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem described in #16 bugged me to.
Therefore I followed the recommendation I changed the implementation to use create-jest-worker. I hope I didn't get it wrong but all tests are running and my own problems with the original implementation are gone as well.