remove extra event listener #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jehy
force-pushed
the
remove-extra-limitter
branch
from
d851670
to
f189eb1
Compare
jehy
force-pushed
the
remove-extra-limitter
branch
from
f189eb1
to
04a8f09
Compare
|
All tests besides Node 4 pass and Node 4 fails because yarn does not support node 4 any more. |
jehy
changed the title
|
We should remove yarn and just use npm; that way we can use |
ljharb
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug #21.
Seems like event listener and onEnd functions are not needed so I simply removed them.