Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testscript: relax constraints around actual source in cmp with update #107

Merged
merged 1 commit into from Jul 31, 2020

Commits on Jul 31, 2020

  1. testscript: relax constraints around actual source in cmp with update

    There are currently constraints on the actual source for a failed cmp
    comparison when Params.UpdateScripts is true: the actual must be either
    stdout or stderr.
    
    However it's unclear why this constraint is necessary.
    
    Indeed it's a painful constraint when the actual source in a comparison
    is file written by a previous command.
    
    Relax this constraint because, after discussion with @mvdan and
    @rogpeppe, we believe it is safe to do so.
    
    Add a test for this new logic where the actual is a file that is part of
    the archive.
    myitcv committed Jul 31, 2020
    Copy the full SHA
    28c666f View commit details
    Browse the repository at this point in the history