Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testscript: explore addition of io/fs.FS to Params #134

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

testscript: explore addition of io/fs.FS to Params #134

wants to merge 1 commit into from

Conversation

myitcv
Copy link
Collaborator

@myitcv myitcv commented Mar 1, 2021

DO NOT SUBMIT

@myitcv
Copy link
Collaborator Author

myitcv commented Mar 1, 2021

The build failures are as a result of golang/go#40067 (comment). So whilst not directly caused by this change, this change does exacerbate the situation.

@myitcv
Copy link
Collaborator Author

myitcv commented Mar 2, 2021

Per a quick chat with @mvdan, perhaps a better approach here is to walk the entire io/fs.FS for .txt files, rather than simply globbing at the root. This would work well, because the caller would be entirely in control over what is exposed via the FS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@myitcv