Skip to content

Commit

Permalink
ci: use upstream patch
Browse files Browse the repository at this point in the history
To get the XDebug 3 INI setting we need, we require a bug fix branch
from upstream. Switch to that for now.

@see shivammathur/setup-php#392
  • Loading branch information
Bishop Bettini committed Jan 13, 2021
1 parent c5b41b2 commit c1866d7
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions .github/workflows/ci-2.x.yml
Expand Up @@ -45,8 +45,9 @@ jobs:
# has paths for with- and without- XDebug, and we want to test both of them.
# However, we require XDebug for code coverage, so before XDebug 3 there was
# no way to test the without-XDebug code path. Now we can, so we do.
# Note: INI values with embedded commas need to have their value quoted.
# @see https://xdebug.org/docs/all_settings#mode
xdebug3-mode: ["xdebug.mode=develop,coverage", "xdebug.mode=coverage"]
xdebug3-mode: ["xdebug.mode='develop,coverage'", "xdebug.mode=coverage"]
include:
# 7.4 introduced an engine wide flag that disables arguments in
# backtraces. The default in 7.4 is On. However, we have tests that
Expand Down Expand Up @@ -78,11 +79,11 @@ jobs:
uses: actions/checkout@v2

- name: Install PHP and composer environment
uses: shivammathur/setup-php@v2
uses: shivammathur/setup-php@develop
with:
php-version: ${{ matrix.php }}
extensions: curl
ini-values: ${{ matrix.ini }}, "${{ matrix.xdebug3-mode }}"
ini-values: ${{ matrix.ini }}, ${{ matrix.xdebug3-mode }}
coverage: xdebug

- name: Get composer cache directory
Expand Down

0 comments on commit c1866d7

Please sign in to comment.