New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: move node-validation to seprate file #584
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
✅ Deploy Preview for rolldown-rs canceled.
|
I get you. But the better solution would be removing |
Or should we say the |
CI action has many jobs, As far as I know only |
As I was saying, it's useless and we have to bare with it. You will notice that currently your PR doesn't not run Skipped actions by "path ignore" won't pass the checks of github. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this one first. I will refactor them using https://github.com/dorny/paths-filter later.
Description
pnpm format:ci
will format Markdown files. but the ci action will ignore markdown changes. So I think we should do a lint check in the new action.Test Plan