Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: move node-validation to seprate file #584

Merged
merged 1 commit into from Mar 15, 2024

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Mar 15, 2024

Description

pnpm format:ci will format Markdown files. but the ci action will ignore markdown changes. So I think we should do a lint check in the new action.

Test Plan


Copy link
Member Author

Dunqing commented Mar 15, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite Graphite

Copy link

netlify bot commented Mar 15, 2024

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 929cf12
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/65f44c5b0101930008df0e0d

@hyf0
Copy link
Member

hyf0 commented Mar 15, 2024

I get you. But the better solution would be removing paths-ignore: in CI.yaml. Due to the "Status check" of github is static and running these actions are required. We need to bare with useless action running for some PRs.

@hyf0
Copy link
Member

hyf0 commented Mar 15, 2024

I get you. But the better solution would be removing paths-ignore: in CI.yaml. Due to the "Status check" of github is static and running these actions are required. We need to bare with useless action running for some PRs.

Or should we say the path ignore is not smart enough. It should treat skipped actions as completed successfully rather than skipped.

@Dunqing
Copy link
Member Author

Dunqing commented Mar 15, 2024

I get you. But the better solution would be removing paths-ignore: in CI.yaml. Due to the "Status check" of github is static and running these actions are required. We need to bare with useless action running for some PRs.

CI action has many jobs, As far as I know only node-validation needs to remove path_ignores. but this causes all other jobs to be executed, so I moved it to a new action to avoid useless CI check

@hyf0
Copy link
Member

hyf0 commented Mar 15, 2024

I get you. But the better solution would be removing paths-ignore: in CI.yaml. Due to the "Status check" of github is static and running these actions are required. We need to bare with useless action running for some PRs.

CI action has many jobs, As far as I know only node-validation needs to remove path_ignores. but this causes all other jobs to be executed, so I moved it to a new action to avoid useless CI check

As I was saying, it's useless and we have to bare with it. You will notice that currently your PR doesn't not run cargo test action and it's required to merge this PR. The problem is that github can't set what actions are required dynamically, so we need to set needed actions required. That's where we hit the "path ignore" problem.

Skipped actions by "path ignore" won't pass the checks of github.

Copy link
Member

@hyf0 hyf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this one first. I will refactor them using https://github.com/dorny/paths-filter later.

@hyf0 hyf0 merged commit 3a19b29 into main Mar 15, 2024
8 checks passed
@hyf0 hyf0 deleted the 03-15-ci_move_node-validation_to_seprate_file branch March 15, 2024 14:08
@hyf0 hyf0 mentioned this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants