Log more robustly when JSON parsing fails

rollup · Nov 30, 2022 · 0430284 · 0430284
1 parent ca7a668
commit 0430284
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/packages/json/src/index.js b/packages/json/src/index.js
@@ -24,8 +24,7 @@ export default function json(options = {}) {
         };
       } catch (err) {
         const message = 'Could not parse JSON file';
-        const position = parseInt(/[\d]/.exec(err.message)[0], 10);
-        this.warn({ message, id, position });
+        this.warn({ message, id, cause: err });
         return null;
       }
     }

diff --git a/packages/json/test/test.js b/packages/json/test/test.js
@@ -81,11 +81,11 @@ test('handles garbage', async (t) => {
     onwarn: (warning) => warns.push(warning)
   }).catch(() => {});
 
-  const [{ message, id, position, plugin }] = warns;
+  const [{ message, id, cause, plugin }] = warns;
 
   t.is(warns.length, 1);
   t.is(plugin, 'json');
-  t.is(position, 1);
+  t.true(cause instanceof SyntaxError);
   t.is(message, 'Could not parse JSON file');
   t.regex(id, /(.*)bad.json$/);
 });