fix(node-resolve): handle circular commonjs (#1259)

rollup · Sep 8, 2022 · 5cf48e9 · 5cf48e9
1 parent 81e2985
commit 5cf48e9
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 1 deletion.
diff --git a/packages/node-resolve/src/index.js b/packages/node-resolve/src/index.js
@@ -285,7 +285,7 @@ export function nodeResolve(opts = {}) {
           // `moduleSideEffects` information.
           const resolvedResolved = await this.resolve(resolved.id, importer, {
             ...resolveOptions,
-            custom: { ...custom, 'node-resolve': { resolved } }
+            custom: { ...custom, 'node-resolve': { ...custom['node-resolve'], resolved } }
           });
           if (resolvedResolved) {
             // Handle plugins that manually make the result external

diff --git a/packages/node-resolve/test/fixtures/cyclic-commonjs/main.js b/packages/node-resolve/test/fixtures/cyclic-commonjs/main.js
@@ -0,0 +1,4 @@
+exports.main = 'main';
+const other = require('./other.js');
+
+t.is(other.main, 'main');
diff --git a/packages/node-resolve/test/fixtures/cyclic-commonjs/other.js b/packages/node-resolve/test/fixtures/cyclic-commonjs/other.js
@@ -0,0 +1,3 @@
+const { main } = require('./main.js');
+
+exports.main = main;
diff --git a/packages/node-resolve/test/test.js b/packages/node-resolve/test/test.js
@@ -44,6 +44,21 @@ test('finds and converts a basic CommonJS module', async (t) => {
   t.is(module.exports, 'It works!');
 });
 
+test('handles cyclic CommonJS modules', async (t) => {
+  const bundle = await rollup({
+    input: 'cyclic-commonjs/main.js',
+    onwarn(warning) {
+      if (warning.code !== 'CIRCULAR_DEPENDENCY') {
+        t.fail(`Unexpected warning:\n${warning.code}\n${warning.message}`);
+      }
+    },
+    plugins: [nodeResolve(), commonjs()]
+  });
+  const { module } = await testBundle(t, bundle);
+
+  t.is(module.exports.main, 'main');
+});
+
 test('handles a trailing slash', async (t) => {
   const bundle = await rollup({
     input: 'trailing-slash.js',