fix(pluginutils): add current working dirctory when pattern starts wi…

…th one * (#1547)
rollup · Aug 13, 2023 · 89ceb2a · 89ceb2a
1 parent a01a075
commit 89ceb2a
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 7 deletions.
diff --git a/packages/pluginutils/src/createFilter.ts b/packages/pluginutils/src/createFilter.ts
@@ -8,7 +8,7 @@ import ensureArray from './utils/ensureArray';
 import normalizePath from './normalizePath';
 
 function getMatcherString(id: string, resolutionBase: string | false | null | undefined) {
-  if (resolutionBase === false || isAbsolute(id) || id.startsWith('*')) {
+  if (resolutionBase === false || isAbsolute(id) || id.startsWith('**')) {
     return normalizePath(id);
   }
 

diff --git a/packages/pluginutils/test/createFilter.ts b/packages/pluginutils/test/createFilter.ts
@@ -134,6 +134,20 @@ test('does not add current working directory when pattern is an absolute path',
   t.falsy(filter(resolve('..', 'c')));
 });
 
+test('does not add current working directory when pattern starts with character **', (t) => {
+  const filter = createFilter(['**/*']);
+
+  t.truthy(filter(resolve('a')));
+  t.truthy(filter(resolve('..', '..', 'a')));
+});
+
+test('add current working directory when pattern starts with one *', (t) => {
+  const filter = createFilter([`*`]);
+
+  t.truthy(filter(resolve('a')));
+  t.falsy(filter(resolve('..', '..', 'a')));
+});
+
 test('normalizes path when pattern is an absolute path', (t) => {
   const filterPosix = createFilter([`${resolve('.')}/*`]);
   const filterWin = createFilter([`${resolve('.')}\\*`]);
@@ -161,9 +175,3 @@ test('normalizes path when pattern has resolution base', (t) => {
   t.truthy(filterPosix(resolve('test/a')));
   t.truthy(filterWin(resolve('test/a')));
 });
-
-test('does not add current working directory when pattern starts with a glob', (t) => {
-  const filter = createFilter(['**/*']);
-  t.truthy(filter(resolve('a')));
-  t.truthy(filter(resolve('..', '..', 'a')));
-});